*-rtl.css files are eliminated in Drupal 8 [#3151592]

Change record: *-rtl.css files are eliminated in Drupal 8. Use [dir="rtl"] in stylesheets to target right-to-left language styling instead

We need to update our widget .css files to account for this.

Comment	File	Size	Author
#11	fivestar-rtl-3151592-11.patch	1.72 KB	kiseleva.t
#11	8.x-1.x: PHP 7.3 & MySQL 5.7, D9.2.10 4 pass
#6	3151592-6-rtl-comments.patch	5.49 KB	TR
#6	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.8 4 pass
#3	3151592-3-dir-rtl.patch	12.15 KB	TR
#3	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.8 4 pass

Issue fork fivestar-3151592

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3151592--rtl.css-files-are changes, plain diff MR !7
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

14 June 2020 at 21:03

TR created an issue. See original summary.

Comment #2

TR CreditAttribution: TR commented 14 June 2020 at 21:04

Title:

*-rtl.css are eliminated in Drupal 8

» *-rtl.css files are eliminated in Drupal 8

Comment #3

TR CreditAttribution: TR commented 22 June 2020 at 00:29

Status:

Active

» Needs review

File	Size
3151592-3-dir-rtl.patch	12.15 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.8 4 pass

I'm going to do this is stages so that it's easier to review and ensure that I'm not breaking things.

First step is to add [dir="rtl"] to all the rulesets in the *-rtl.css files. This will have no functional effect, since the *-rtl.css files are not used in D8, but it will prepare these rulesets for merging with the main .css files in a way that's easy to review. Taking this step also made me look at each line in these css files and helped me catch a number of errors in the *.rtl.css files, which I will fix in the next step.

Comment #4

TR CreditAttribution: TR commented 22 June 2020 at 00:29

Comment #5

22 June 2020 at 00:42

TR committed ca5ab2f on 8.x-1.x

Issue #3151592 by TR: *-rtl.css files are eliminated in Drupal 8: Step 1...

Comment #6

TR CreditAttribution: TR commented 22 June 2020 at 03:47

File	Size
3151592-6-rtl-comments.patch	5.49 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.8 4 pass

Correct wrong RTL comments, and fix two rulesets like this:

-.fivestar-outlinediv.rating div a:hover {
+.fivestar-outline div.rating div a:hover {

Comment #7

22 June 2020 at 03:55

TR committed 587f993 on 8.x-1.x

Issue #3151592 by TR: *-rtl.css files are eliminated in Drupal 8: Step 2...

Comment #8

TR CreditAttribution: TR commented 8 July 2020 at 01:30

Issue tags:

+RTL

Comment #9

1 June 2022 at 13:45

kiseleva.t made their first commit to this issue’s fork.

Comment #10

1 June 2022 at 13:52

kiseleva.t opened merge request !7

Comment #11

kiseleva.t CreditAttribution: kiseleva.t as a volunteer and at FFW commented 1 June 2022 at 13:54

File	Size
fivestar-rtl-3151592-11.patch	1.72 KB
8.x-1.x: PHP 7.3 & MySQL 5.7, D9.2.10 4 pass

Comment #12

TR CreditAttribution: TR commented 1 June 2022 at 16:52

The patch in #11 is wrong. -rtl.css should never be included in libraries, even before the change mentioned in the issue summary. All the LTR and RTL rules need to be combined into one .css file, and that hasn't been done yet because there are still large differences between the LTR and RTL styles that haven't been tested by anyone. See #3 for a description of what I was trying to do.