Add integration with Feeds module [#3151403]

Comment	File	Size	Author
#5	google_map_field-feeds_integration-3151403-5.patch	1.47 KB	VladimirAus
#2	google_map_field-feeds_integration-3151403-2.patch	4.25 KB	VladimirAus
#2	feeds-google-map-field-source.png	220.03 KB	VladimirAus

Comment #1

13 June 2020 at 13:45

VladimirAus created an issue. See original summary.

Log in or register to post comments

Comment #2

VladimirAus

English

Brisbane 🇦🇺

CreditAttribution: VladimirAus at Tomato Elephant Studio commented 14 June 2020 at 07:10

Issue summary:	View changes
Status:	Active	» Needs review

File	Size
feeds-google-map-field-source.png	220.03 KB
google_map_field-feeds_integration-3151403-2.patch	4.25 KB

To test:

Enable feeds
Create content type with google map field
Create feeds type to incorporate google map field (see screenshot)
Process CSV with latitude and longitude

Log in or register to post comments

Comment #4

scot.hubbard CreditAttribution: scot.hubbard commented 14 June 2020 at 11:03

I have added the patch to the latest dev version. One coding standards violation needed fixing:

FILE: /var/www/drupal8dev.local/web/modules/custom/google_map_field/src/Feeds/Target/GoogleMap.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
144 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
-----------------------------------------------------------------------------------------------------------------------

Apart from that it all looks good. Once RTBC I'll merge into stable release.

Log in or register to post comments

Comment #5

VladimirAus

English

Brisbane 🇦🇺

CreditAttribution: VladimirAus at Tomato Elephant Studio commented 14 June 2020 at 11:44

File	Size
google_map_field-feeds_integration-3151403-5.patch	1.47 KB

@scot.hubbard Which drupal standards are you running? I ran phpcs --standard=DrupalPractice,Drupal --extensions=php,module,inc,install,test,profile,theme and got

FILE: ...l/modules/custom/google_map_field/src/Feeds/Target/GoogleMap.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 47 | WARNING | Unused variable $config_id.
----------------------------------------------------------------------

Patch added.

Log in or register to post comments

Comment #6

scot.hubbard CreditAttribution: scot.hubbard commented 14 June 2020 at 12:00

@validimirAus - I was only running phpcs --standard=Drupal, but with both DrupalPractice and Drupal, I get:

phpcs --standard=DrupalPractice,Drupal .

FILE: /var/www/drupal8dev.local/web/modules/custom/google_map_field/src/Feeds/Target/GoogleMap.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------
47 | WARNING | Unused variable $config_id.
144 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
-----------------------------------------------------------------------------------------------------------------------

Time: 1.76 secs; Memory: 14MB

Removing the single space from the start of the string you are translating removes the warning from line 144.