Problem/Motivation

Lets remove usage of "blacklist" and "whitelist" in Big Pipe module.

They are:

  • An historic bad labelling of people
  • Provide no context: "what is listed in them"?

Proposed resolution

TBD

Remaining tasks

User interface changes

None

API changes

@todo

Data model changes

@todo

Release notes snippet

@todo

CommentFileSizeAuthor
#4 3151098-4.patch763 bytesrik-dev
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Issue summary: View changes
Parent issue: » #2993575: Remove usage of "blacklist", "whitelist", use better terms instead
Related issues: -#2993575: Remove usage of "blacklist", "whitelist", use better terms instead
rik-dev’s picture

rik-dev CreditAttribution: rik-dev at DevBranch commented
Assigned: Unassigned » rik-dev
rik-dev’s picture

rik-dev CreditAttribution: rik-dev at DevBranch commented
Status: Active » Needs review
FileSize
3151098-4.patch763 bytes
rik-dev’s picture

rik-dev CreditAttribution: rik-dev at DevBranch commented
Assigned: rik-dev » Unassigned
dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Needs review » Reviewed & tested by the community

Wow, that was the easiest one of these, yet! ;)

% grep -ir white core/modules/big_pipe
core/modules/big_pipe/src/Render/Placeholder/BigPipeStrategy.php:        // Inform BigPipe' JavaScript known BigPipe placeholder IDs (a whitelist).

Patch removes this from the comment, nothing less, nothing more.

RTBC!

Thanks,
-Derek

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed faca97047e to 9.1.x and 1894efe816 to 9.0.x and 99b7a24038 to 8.9.x. Thanks!

Backported to 8.9.x as this is only a comment.

  • alexpott committed faca970 on 9.1.x 
    Issue #3151098 by rik-dev, dww: Replace use of whitelist/blacklist in...

  • alexpott committed 1894efe on 9.0.x 
    Issue #3151098 by rik-dev, dww: Replace use of whitelist/blacklist in...

  • alexpott committed 99b7a24 on 8.9.x 
    Issue #3151098 by rik-dev, dww: Replace use of whitelist/blacklist in...
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

I didn't get to this in time as the maintainer of this component, but I obviously totally support this change! 👍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.