Replace use of whitelist/blacklist in file_munge_filename() and its tests

Please take a look into #5 regarding related test - \Drupal\KernelTests\Core\File\NameMungingTest

Huge +1 to this effort. Long overdue!

As someone far too familiar with file_munge_filename(), I can safely say that part of the change is ready. But great catch in #7 for also fixing the test(s). I checked core/modules/file/tests/src/* and didn't find anything else that needs help. So yeah, I think it's just core/tests/Drupal/KernelTests/Core/File/NameMungingTest.php

Thanks!
-Derek

@alexpott Thanks for review.

@rik-dev: Please get in the habit of uploading an interdiff with your patches. Thanks!

1. +++ b/core/tests/Drupal/KernelTests/Core/File/NameMungingTest.php
   @@ -66,16 +66,16 @@ public function testMungeIgnoreInsecure() {
   +   * Allowed extensions are ignored by file_munge_filename().
   

   If we're changing it anyway, we should probably use:

   "Tests that allowed extensions..."

   since PHPDoc comments are supposed to start with a verb.

2. +++ b/core/tests/Drupal/KernelTests/Core/File/NameMungingTest.php
   @@ -66,16 +66,16 @@ public function testMungeIgnoreInsecure() {
   +    // Declare our allowed extension. The declared extensions should
        // be case insensitive so test using one with a different case.
   

   The 2nd line can now wrap more words into the previous line.

   Also, maybe start with:

   "Declare that our extension is allowed."

+++ b/core/tests/Drupal/KernelTests/Core/File/NameMungingTest.php
@@ -66,16 +66,16 @@ public function testMungeIgnoreInsecure() {
+    $this->assertSame($munged_name, $this->nameWithUcExt, new FormattableMarkup('The new filename (%munged) matches the original (%original) once the extension has been allowed.', ['%munged' => $munged_name, '%original' => $this->nameWithUcExt]));
...
+    $this->assertSame($munged_name, $this->name, new FormattableMarkup('The new filename (%munged) matches the original (%original) also when the allowed extension is in uppercase.', ['%munged' => $munged_name, '%original' => $this->name]));

While we're touching these lines, we could also completely remove the assertion message and all of new FormattableMarkup() here, too. If so, check if those are the last FormattableMarkup used in this test class, and if so, remove the use statement at the top of the file. But that's perhaps scope creep, so if you ignore this comment, we can clean that up later in some other issue instead.

Thanks,
-Derek

@dww Thanks for review and thanks a lot of interdiff I didn’t know about this, so will use this in future.

+++ b/core/tests/Drupal/KernelTests/Core/File/NameMungingTest.php
@@ -66,16 +66,16 @@ public function testMungeIgnoreInsecure() {
+    // Declare that our allowed extension. The declared extensions should
     // be case insensitive so test using one with a different case.

Sorry if I wasn't clear, but you missed what I was asking for in #10.2. "Declare that our allowed extension." isn't a sentence. And "be" can wrap into the previous line and still be under 80 chars wide.

This comment should be:

    // Declare that our extension is allowed. The declared extensions should be
    // case insensitive, so test using one with a different case.

Thanks,
-Derek

That looks great, thanks!

Would still be useful to see interdiffs for these, but this is small enough I can just re-review each time. But seriously, please make this part of your workflow whenever you upload a new patch to an issue that already has a patch (whether the previous patch was yours or not).

Thanks!
-Derek

p.s. Crediting all the contributors so far...