Make the variable naming less confusing in \Drupal\views\ViewExecutableFactory::get()

Problem/Motivation

  /**
   * Instantiates a ViewExecutable class.
   *
   * @param \Drupal\views\ViewEntityInterface $view
   *   A view entity instance.
   *
   * @return \Drupal\views\ViewExecutable
   *   A ViewExecutable instance.
   */
  public function get(ViewEntityInterface $view) {
    $view = new ViewExecutable($view, $this->user, $this->viewsData, $this->routeProvider);
    $view->setRequest($this->requestStack->getCurrentRequest());
    return $view;
  }

The $view parameter passed in is an instance of ViewEntityInterface, at the first line of the method body, it becomes an instance of ViewExecutable immediately, which is confusing. And not sure if it is a bug with type-hinting.

Proposed resolution

  /**
   * Instantiates a ViewExecutable class.
   *
   * @param \Drupal\views\ViewEntityInterface $view
   *   A view entity instance.
   *
   * @return \Drupal\views\ViewExecutable
   *   A ViewExecutable instance.
   */
  public function get(ViewEntityInterface $view) {
    $view_executable = new ViewExecutable($view, $this->user, $this->viewsData, $this->routeProvider);
    $view_executable->setRequest($this->requestStack->getCurrentRequest());
    return $view_executable;
  }

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet