Problem/Motivation

This error is produced by Upgrade Status:

web/profiles/cappuccino/config/sync/core.base_field_override.block_content.basic.info.yml
Add core_version_requirement: ^8 || ^9 to profiles/cappuccino/config/sync/core.base_field_override.block_content.basic.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

The problem here is the following.

  1. One of the things Upgrade Status does is it checks info.yml files for core_version_requirement keys.
  2. This used to be done only to the root info.yml file of the project, but since #3132387: Subextension info.yml files not checked during module scan it is found everywhere under a project (except tests).
  3. As @mr.york points out, this becomes a problem when you have configuration yml files in your project which may also end up being named something.info.yml.

Proposed resolution

Avoid identifying info.yml files as extension definitions when a .yml file has more dots in it. This way we can ensure that a /config/ subdirectory is not ruled out for placing subextensions.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3145821.patch909 bytesGábor Hojtsy
#8 interdiff_4-8.txt6.57 KBankitsingh0188
#8 3145821-8.patch8.93 KBankitsingh0188
#7 interdiff_4-7.txt5 KBankitsingh0188
#7 3145821-7.patch7.36 KBankitsingh0188
#4 Screenshot 2020-06-05 at 12.39.34 PM.png190.54 KBankitsingh0188
#4 Screenshot 2020-06-05 at 1.03.47 PM.png16.06 KBankitsingh0188
#4 3145821-4.patch2.36 KBankitsingh0188
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mr.york created an issue. See original summary.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Title: Search in profile config directory » Config files with names ending in info.yml should not be identified as extensions

Thanks for the report. Retitled for accuracy.

ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
CreditAttribution: ankitsingh0188 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » ankitsingh0188
ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
CreditAttribution: ankitsingh0188 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: ankitsingh0188 » Unassigned
Status: Active » Needs review
FileSize
3145821-4.patch2.36 KB
Screenshot 2020-06-05 at 1.03.47 PM.png16.06 KB
Screenshot 2020-06-05 at 12.39.34 PM.png190.54 KB

Created the patch with the latest code of the module. The module is now compatible with the drupal version 9.

No deprecations found.

Status: Needs review » Needs work

The last submitted patch, 4: 3145821-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
CreditAttribution: ankitsingh0188 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » ankitsingh0188

Working on the test case failures.

ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
CreditAttribution: ankitsingh0188 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3145821-7.patch7.36 KB
interdiff_4-7.txt5 KB
ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
CreditAttribution: ankitsingh0188 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3145821-8.patch8.93 KB
interdiff_4-8.txt6.57 KB
ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
CreditAttribution: ankitsingh0188 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: ankitsingh0188 » Unassigned
Status: Needs work » Needs review
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Active

@ankit.singh: two questions:

1. How are your patches related to this issue? The issue is about info.yml file detection being wrong.
2. Why are you "fixing" errors that we need to be present in the module to test for them. Upgrade Status is about finding those issues and we need files with issues to test with. We should not "fix" them.

ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
CreditAttribution: ankitsingh0188 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented

@gábor-hojtsy

I think some confusion is there. Please brief me on what to do next here.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue summary: View changes

Updated the issue summary with what happens and what I think should be done to fix it.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Active » Needs review
FileSize
3145821.patch909 bytes

This is a workable solution most likely.

  • Gábor Hojtsy committed 3c22a57 on 8.x-2.x 
    Issue #3145821 by Gábor Hojtsy, mr.york: Config files with names ending...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Fixed

Let's go!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.