Commerce Shipping uses "Order Shipments" when it should be "Order shipments". For reference, the User Interface Standards say: Page titles, links (in menus, too), and headings in Drupal should generally use sentence case capitalization, where only the first word is capitalized, except for proper nouns and other words that are generally capitalized by a more specific rule. Examples of sentence case capitalization include the following: "Block administration", "List menus", "Install new theme".

Theoretically, the affected view machine name "order_shipments" should also be renamed to "commerce_order_shipments" (to match the rest of Commerce core), but that's a substantially thicker issue than just the sentence case string change that this issue is patching.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Morbus Iff created an issue. See original summary.

Morbus Iff’s picture

Status: Active » Needs review
FileSize
680 bytes

Status: Needs review » Needs work

The last submitted patch, 2: sentence_case-3145782-2.patch, failed testing. View results

Morbus Iff’s picture

Status: Needs work » Reviewed & tested by the community

Failed tests are unrelated to this issue.

  • mglaman committed 7e3c5f0 on 8.x-2.x authored by Morbus Iff
    Issue #3145782 by Morbus Iff: Incorrect sentence case for "Order...
mglaman’s picture

Assigned: Morbus Iff » Unassigned
Status: Reviewed & tested by the community » Fixed

Looks good to me, and matches other interface areas. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.