In Pushbutton's page.tpl.php footer section, the footer items are all wrapped in paragraph tags. When you have a block in the footer, this will not validate because div tags cannot be inside of p tags.

Steps to repeat:

  • Clean install from HEAD
  • Switch to Pushbutton theme leaving the Powered by Drupal block enabled in the footer
  • Validate the page at http://validator.w3.org

Also, the body element has the background color set to #ffffff in two places: inside the body tag in page.tpl.php (using bgcolor="") and in styles.css. Removing the unnecessary color setting from page.tpl.php.

CommentFileSizeAuthor
pushbutton-footer-paragraphs.patch833 bytesm1mic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m1mic’s picture

m1mic CreditAttribution: m1mic commented
Status: Active » Needs review
lilou’s picture

lilou CreditAttribution: lilou commented
Status: Needs review » Reviewed & tested by the community

1. See : http://www.w3.org/TR/REC-html40/struct/text.html#h-9.3.1

The P element represents a paragraph. It cannot contain block-level elements (including P itself).

We discourage authors from using empty P elements. User agents should ignore empty P elements.

2. I confirm bgcolor is set both in template and css.

So mark as RTBC.

Dries’s picture

Dries CreditAttribution: Dries commented
Version: 7.x-dev » 6.x-dev

Committed to CVS HEAD. Lowering version to DRUPAL-6.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Version: 6.x-dev » 5.x-dev

Committed to Drupal 6.x as well. Moving to 5.x.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Patch (to be ported)

Does not apply to 5.x.

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Status: Patch (to be ported) » Closed (won't fix)

Marking as won't fix as d5 is end of life.