CommentFileSizeAuthor
#6 3144396-6.patch1.46 KBjaperry
#2 captcha_3144396_1.patch12.06 KBkavitasonawane
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kavitasonawane created an issue. See original summary.

kavitasonawane’s picture

kavitasonawane CreditAttribution: kavitasonawane commented
Status: Active » Needs review
FileSize
captcha_3144396_1.patch12.06 KB

Status: Needs review » Needs work

The last submitted patch, 2: captcha_3144396_1.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » mrinalini9
mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: mrinalini9 » Unassigned
japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Needs work » Needs review
FileSize
3144396-6.patch1.46 KB

t() is meant to be used in .module (procedural code). Also, without the StringTranslationTrait, '$this' wont' work in the service.

  • japerry committed d16214a on 8.x-1.x 
    Issue #3144396: Add StringTranslationTrait to CaptchaService.
japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.