The current shipped configuration (config/*/*.yml) is slightly out of date in various aspects. These are usually just one or two line differences here and there, but they're considered "changed configuration" in Configuration Update Manager because of these differences. To reproduce, install https://www.drupal.org/project/config_update, then head to admin/config/development/configuration/report/type/system.all.

CommentFileSizeAuthor
#2 yaml_update-3143827-2.patch2.8 KBMorbus Iff
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Morbus Iff created an issue. See original summary.

Morbus Iff’s picture

Morbus Iff
they/them
CreditAttribution: Morbus Iff commented
Status: Active » Needs review
FileSize
yaml_update-3143827-2.patch2.8 KB

Status: Needs review » Needs work

The last submitted patch, 2: yaml_update-3143827-2.patch, failed testing. View results

Morbus Iff’s picture

Morbus Iff
they/them
CreditAttribution: Morbus Iff commented
Status: Needs work » Reviewed & tested by the community

The failed test appears to be failing for other issues as well:

* https://www.drupal.org/project/commerce_shipping/issues/3137226

Moving to RTBC.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Assigned: Morbus Iff » Unassigned
Status: Reviewed & tested by the community » Needs work 
+++ b/config/install/core.entity_view_display.commerce_shipment.default.checkout.yml
@@ -19,9 +19,9 @@ content:
-  adjustments: true

+++ b/config/install/core.entity_view_display.commerce_shipment.default.default.yml
@@ -77,5 +77,5 @@ content:
-  adjustments: true

+++ b/config/install/core.entity_view_display.commerce_shipment.default.user.yml
@@ -15,18 +15,20 @@ content:
-  adjustments: true

Shipments have adjustments, again. See #2996465: Put back adjustments to Shipments, so this probably needs to stay.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs work » Needs review

Ah,

    $fields['adjustments'] = BaseFieldDefinition::create('commerce_adjustment')
      ->setLabel(t('Adjustments'))
      ->setCardinality(BaseFieldDefinition::CARDINALITY_UNLIMITED)
      ->setDisplayConfigurable('form', FALSE)
      ->setDisplayConfigurable('view', FALSE);

It's not configurable, so those changes do make sense

  • mglaman committed 3f85a89 on 8.x-2.x authored by Morbus Iff 
    Issue #3143827 by Morbus Iff: Shipped YAML config is slightly out of...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs review » Fixed

Looks good, clears up the config report. Not making the change for commerce_checkout.commerce_checkout_flow.shipping as that always changes its module dependencies (mine required commerce_demo, payment, and promotion as well.) So we'll just keep core config objects up to date.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.