Problem/Motivation

As title

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 interdiff-6-9.txt2.97 KBjungle
#9 3143592-9.patch18.62 KBjungle
#8 interdiff.txt1.08 KBandypost
#7 interdiff.txt615 bytesandypost
#6 interdiff-4-6.txt598 bytesjungle
#6 3143592-6.patch17.3 KBjungle
#4 interdiff-2-4.txt16.92 KBjungle
#4 3143592-4.patch17.26 KBjungle
#2 3143592-2.patch15.25 KBjungle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Active » Needs review
FileSize
3143592-2.patch15.25 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented 
+++ b/examples.info.yml
@@ -2,7 +2,6 @@ name: Examples for Developers
-core: 8.x
 core_version_requirement: ^8 || ^9

+++ b/modules/ajax_example/ajax_example.info.yml
@@ -2,7 +2,6 @@ name: 'AJAX Example'
-core: 8.x
 core_version_requirement: ^8 || ^9

+++ b/modules/batch_example/batch_example.info.yml
@@ -2,7 +2,6 @@ name: Batch Example
-core: 8.x
 core_version_requirement: ^8 || ^9

As the patch for 3.x let's fix core_version_requirement: ^9 same time

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
FileSize
3143592-4.patch17.26 KB
interdiff-2-4.txt16.92 KB

Thanks for your comment!

Addressing #3

Status: Needs review » Needs work

The last submitted patch, 4: 3143592-4.patch, failed testing. View results

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs work » Needs review
FileSize
3143592-6.patch17.3 KB
interdiff-4-6.txt598 bytes

One more fix.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community
FileSize
interdiff.txt615 bytes

Checked with `git grep 8.x` and only one mention found (probably could be added on commit

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
interdiff.txt1.08 KB

And composer link

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
FileSize
3143592-9.patch18.62 KB
interdiff-6-9.txt2.97 KB

Addressing #7, #8 and remove "in Drupal 8 " from the description in .info.yml.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Nice! Looks totally ready to go

  • jungle committed 65f909b on 3.x 
    Issue #3143592 by jungle, andypost: Removing the core key from .info.yml...
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Many thanks! @andypost!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
CreditAttribution: hanoii commented

Any reason removing D8, why not making it supporting 8.8 or 8.9+ and D9?

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
CreditAttribution: hanoii commented

And now that I installed 3.0.1 I can't upgrade :(.. nothing too bad obviously, just mentioning.