Problem/Motivation

This release uses the path_alias.manager service but isn't available until Drupal 8.8

Proposed resolution

Specifying some more strict constraints to the required Drupal Core version in .info.yml and (possibly) in composer.json but because there are no specific dependencies it can be removed because it's auto generated.

Remaining tasks

Change .info.yml core requirements

CommentFileSizeAuthor
#5 change-core-requirements-3143544-5.patch1.19 KBjonas139
#4 change-core-requirements-3143544-4.patch1.15 KBjonas139
#3 change-core-requirements-3143544-3.patch1.15 KBjonas139

Comments

jonas139 created an issue. See original summary.

jonas139’s picture

jonas139 commented
Issue summary: View changes
jonas139’s picture

jonas139 commented
StatusFileSize
new change-core-requirements-3143544-3.patch1.15 KB

I've included a patch where I've change the core requirements in my .info.yml and removed the (obsolete) composer.json.

jonas139’s picture

jonas139 commented
StatusFileSize
new change-core-requirements-3143544-4.patch1.15 KB

Forgot to remove the core key so new patch attached.

jonas139’s picture

jonas139 commented
StatusFileSize
new change-core-requirements-3143544-5.patch1.19 KB

Also included the dependency on path_alias (thanks @jeroent)

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Version: 8.x-1.8 » 8.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

This patch prevents the module from being installed on Drupal 8.7 or earlier.

I agree with @jonas139,

Since this module has no external dependencies, there is no advantage of having a composer.json file in this module.

https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file

If a module does not have any dependencies, or the dependencies are solely other Drupal modules, then a composer.json is not required. However, having a composer.json does not have a negative impact either.

When a module does not have a composer.json,

An advantage of having no composer.json for system_tags is https://packages.drupal.org/8 will use the versions configured in your .info.yml file and composer install/update will respect those constraints, so +1 for me.

  • lammensj committed 20cd317 on 8.x-1.x authored by jonas139 
    Issue #3143544 by jonas139, JeroenT: Version constraint on core version...
lammensj’s picture

lammensj commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.