If you try to export a file with no project selected, you get an empty file. The HTML file has the headline "Upgrade Status report" but nothing else.

Either the export buttons should be greyed out while no projects are selected, or it should say in the exported file that the reason why it is empty is because no projects were selected. I think that the easiest and most user friendly solution is to just grey out the buttons.

CommentFileSizeAuthor
#8 Screenshot 2020-05-28 14.54.46.png428.82 KBzhouhana
#7 3143155-7.patch3.15 KBGábor Hojtsy
#5 3143155.patch4.11 KBGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zhouhana created an issue. See original summary.

zhouhana’s picture

zhouhana CreditAttribution: zhouhana as a volunteer commented
Issue summary: View changes
zhouhana’s picture

zhouhana CreditAttribution: zhouhana as a volunteer commented
Status: Active » Closed (duplicate)

I realise that this is sort of a duplicate of my other issue, so I'm closing this one.

zhouhana’s picture

zhouhana CreditAttribution: zhouhana as a volunteer commented
Title: Clarify that export buttons only apply to selected items » Clarify that only selected items are exported
Issue summary: View changes
Status: Closed (duplicate) » Active

This wasn't a duplicate after all, the other issue was two issues in one … Sorry for any confusion.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Active » Needs review
FileSize
3143155.patch4.11 KB

Right, when you do not select any items, you get an empty file. When you do select items that do not have results, the individual items will show that there was no result for them. So we can catch the case when there was no project selected. We can also do the same for the scan operation. I also updated the button labels.

Testing welcome.

Status: Needs review » Needs work

The last submitted patch, 5: 3143155.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs work » Needs review
FileSize
3143155-7.patch3.15 KB

Got a bit trigger-happy with the export test labels. The individual screen still has the label without "selected" because we are only dealing with one project there.

zhouhana’s picture

zhouhana CreditAttribution: zhouhana as a volunteer commented
FileSize
Screenshot 2020-05-28 14.54.46.png428.82 KB

3143155-7 didn't work for me; see screenshot.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Postponed (maintainer needs more info)

@zhouhana: hm, did you use composer to install Upgrade Status?

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Title: Clarify that only selected items are exported » Clarify that only selected items are exported, emit an error when nothing is selected for export or scan
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

Worked for me locally, so I'll assume it will work for you when you use composer.

  • Gábor Hojtsy committed ede6c65 on 8.x-2.x 
    Issue #3143155 by Gábor Hojtsy, zhouhana: Clarify that only selected...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.