Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tostinni created an issue. See original summary.

tostinni’s picture

Here is a patch that update the tests to make them compatible with Drupal 9, as they passed I removed the core: 8.x.

There is just this line $accountProxy = new AccountProxy(); where I'm not 100% sure that my change is correct so it needs an extra look at. I used the code found in AccountProxyTest.php to add the EventDispatcher :

$dispatcher = $this->prophesize(EventDispatcherInterface::class);
$accountProxy = new AccountProxy($dispatcher->reveal());
tostinni’s picture

Status: Active » Needs review
Issue tags: +Drupal 9 compatibility

Missing tag

legolasbo’s picture

Status: Needs review » Needs work

The tests fail with Drupal 9, so something is still off with the patch.

tostinni’s picture

So the default tests are falling because they try to run Drupal 9 with MySQL 5.5 when the default version is 5.7.

I fixed the remaining failing tests mainly due to PHPUnit deprecated messages.

PS : this needs to be run also with dev version of term_reference_change, so locally this pass :

$ sudo -u www-data ../../vendor/bin/phpunit --group term_merge
PHPUnit 8.5.5 by Sebastian Bergmann and contributors.

Testing
.......................................................           55 / 55 (100%)

Time: 3.97 minutes, Memory: 929.00 MB

OK (55 tests, 437 assertions)
legolasbo’s picture

I've released the first beta for term_reference_change and adjusted the testbot configuration to use mysql 5.7. Tests still fail, but that's probably due to another patch that's been committed since you submitted your last patch.

mrinalini9’s picture

Fixing test case failure issue in #5 by adding core_version_requirement: ^8 || ^9 in the term_merge_test_events.info.yml file, please review. And not able to add interdiff file as getting some error during creation.
Thanks!

legolasbo’s picture

Status: Needs review » Fixed

yup! that did it. committed and pushed to 8.x-1.x-dev. thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.