Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
A few fixes needs to be applied to prepare for Drupal 9 compatibility.
Comment | File | Size | Author |
---|---|---|---|
#7 | 3142780-7.patch | 6.42 KB | mrinalini9 |
#5 | 3142780-5.patch | 6.01 KB | tostinni |
Comments
Comment #2
tostinni CreditAttribution: tostinni at Agence Propal commentedHere is a patch that update the tests to make them compatible with Drupal 9, as they passed I removed the
core: 8.x
.There is just this line
$accountProxy = new AccountProxy();
where I'm not 100% sure that my change is correct so it needs an extra look at. I used the code found in AccountProxyTest.php to add the EventDispatcher :Comment #3
tostinni CreditAttribution: tostinni at Agence Propal commentedMissing tag
Comment #4
legolasboThe tests fail with Drupal 9, so something is still off with the patch.
Comment #5
tostinni CreditAttribution: tostinni at Agence Propal commentedSo the default tests are falling because they try to run Drupal 9 with MySQL 5.5 when the default version is 5.7.
I fixed the remaining failing tests mainly due to PHPUnit deprecated messages.
PS : this needs to be run also with dev version of term_reference_change, so locally this pass :
Comment #6
legolasboI've released the first beta for term_reference_change and adjusted the testbot configuration to use mysql 5.7. Tests still fail, but that's probably due to another patch that's been committed since you submitted your last patch.
Comment #7
mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commentedFixing test case failure issue in #5 by adding
core_version_requirement: ^8 || ^9
in theterm_merge_test_events.info.yml
file, please review. And not able to add interdiff file as getting some error during creation.Thanks!
Comment #9
legolasboyup! that did it. committed and pushed to 8.x-1.x-dev. thanks!