Problem/Motivation

Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 9.

To read more about this effort by the Drupal Association, please read: Accelerating Drupal 9 module and theme readiness with automated patches

Periodically patches will be added to this issue that remove Drupal 9 deprecations. To stop further patches from being posted simply close this issue(any status besides Active, Needs Review or Needs work) or remove the "ProjectUpdateBotD9" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open(status of Active, Needs Review or Needs work) and the "RectorAutoPatches" tag is left on this issue, new patches will be posted periodically if new deprecations are needed.

    As the Drupal Rector project improves and is able to fix more deprecations the patches posted here will cover more of the deprecations in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecations but don't want new automated patches simply leave this issue open but remove the "RectorAutoPatches" from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again simply add back the "RectorAutoPatches" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful they can simply close this issue(any status besides Active, Needs Review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 9 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear,  use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

CommentFileSizeAuthor
#2 entity_count.1.0.rector.patch357 bytesProject Update Bot
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Project Update Bot created an issue. See original summary.

Project Update Bot’s picture

Status: Active » Needs review
FileSize
357 bytes
Patch for Build #1473

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 0.12.3
  2. palantirnet/drupal-rector: 0.5.4
  3. rector/rector-prefixed: dev-master

Debug info: Run #1473

Project Update Bot’s picture

Issue summary: View changes
Issue tags: +Drupal 9 compatibility

Fixing summary

laura.gates’s picture

Issue summary: View changes
Issue tags: +RectorAutoPatches

mmjvb’s picture

See no reason for changing what the bot suggests and remove support for older D8 versions. That would warrant a new minor release of this module rather than staying with this. It should also point to the development branch rather than a release. Assuming development policy as defined for Drupal.

mmjvb’s picture

Status: Needs review » Needs work
laura.gates’s picture

@mmjvb it doesn't look like there is a dev branch to target this one. While this patch does apply in 8.9, it does not apply correctly in my branch that runs 9.2

mmjvb’s picture

No idea why that is. Normally, when providing a patch the issue is set to dev branch (8.x-1.x) as that is where it is supposed to be applied. 8.x-1.0 is a release (tag, not branch) which doesn't change. Once the change is committed it should tag a new release: 8.x-1.1 or 1.0.1 or 1.1.0 when preferring semantic versioning.
1.0.1 with still having the core key, 1.1.0 when removing the core key.

geoanders’s picture

Version: 8.x-1.0 » 8.x-1.x-dev
Status: Needs work » Fixed
geoanders’s picture

Status: Fixed » Closed (fixed)