Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 9.
To read more about this effort by the Drupal Association, please read: Accelerating Drupal 9 module and theme readiness with automated patches
Periodically patches will be added to this issue that remove Drupal 9 deprecations. To stop further patches from being posted simply close this issue(any status besides Active, Needs Review or Needs work) or remove the "ProjectUpdateBotD9" tag from the issue.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open(status of Active, Needs Review or Needs work) and the "RectorAutoPatches" tag is left on this issue, new patches will be posted periodically if new deprecations are needed.
As the Drupal Rector project improves and is able to fix more deprecations the patches posted here will cover more of the deprecations in the module.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecations but don't want new automated patches simply leave this issue open but remove the "RectorAutoPatches" from the issue.
You can use Drupal Rector yourself to make these patches.
If you want to receive automated patches again simply add back the "RectorAutoPatches" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful they can simply close this issue(any status besides Active, Needs Review or Needs work) and no more automated patches will be posted here.
If the issue is reopened then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 9 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the patch in the comment by Project Update Bot
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | ckeditor_advanced_tab.1.x-dev.rector.patch | 1.13 KB | Project Update Bot |
Issue fork ckeditor_advanced_tab-3139791
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 8.x-1.x
compare - 3139791-automated-drupal-rector changes, plain diff MR !2
1 hidden branch
Comments
Comment #2
Project Update Bot CreditAttribution: Project Update Bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
This patch was created using these packages:
Debug info: Run #1473
Comment #3
Project Update Bot CreditAttribution: Project Update Bot commentedFixing summary
Comment #4
shreyal999 CreditAttribution: shreyal999 at Axelerant commentedVerified and working as expected, Good to Go.
Comment #9
Phil Wolstenholme CreditAttribution: Phil Wolstenholme at CTI Digital commentedI've made a Merge Request which applies the Rector changes and also adds a `composer.json` file so people can easily test this by adding:
To the
repositoriessection of theircomposer.jsonthen running:Comment #10
apadernoTo be compatible with Drupal 9, the module should also stop using the core key in its .info.yml file.
I would also create a Drupal 9 branch, as changing the module requirements is too disruptive to be done once a release candidate version has been created. (The implicit requirement is PHP 7.3, as that is the requirement for Drupal 9.)
Comment #11
apadernoActually, the module should not show the error message but log it.
drupal_get_path()is deprecated in Drupal 9.3; the module should useCKEditorPluginBase::getModulePath().Comment #12
apadernoComment #15
apadernoFor the 2.0.x branch, I replaced the
corekey withcore_version_requirement: ^9.3; I replaced the call todrupal_get_path()(which is deprecated since Drupal 9.3.x) with a call to$this->getModulePath().For the 8.x-1.x branch, I replaced the
corekey withcore_version_requirement: ^8.8 || ^9.The call to
drupal_set_message()has been already replaced with a call to$this->logger->error()(where$this->loggeris properly injected) in #3257715: Log an error when the plugin.js file isn't found.