Replace usages of deprecated AssertLegacyTrait::buildXPathQuery()

Adding the "Deprecated assertions" tag to add this into the kanban board https://contribkanban.com/board/Deprecatedassertions

Fixing CS

Hi, Please review the Patch.

I am working on the test case failures.

Fix for test failures.

Apologies for the interdiff. generating the interdiff file.

Don't know why but interdiff is giving error on this patch so while I am fixing that on my computer below is the change I made from patch #10

In core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php

-    return $this->assertSession()->buildXPathQuery($xpath, ['value' => $value]);
+    return $this->assertSession()->buildXPathQuery($xpath, [':value' => $value]);
   }

Adding interdiff between patch at #10 and #13. Patch at #13 is looks good to me but it has some additional changes like

--- a/core/modules/views/tests/src/Functional/Handler/FieldWebTest.php
 +++ b/core/modules/views/tests/src/Functional/Handler/FieldWebTest.php
 @@ -47,6 +47,9 @@ class FieldWebTest extends ViewTestBase {
      'views_test_data_name' => 'name',
    ];
- 
+
 +  /**
-+   *
++   * {@inheritdoc}
 +   */
    protected function setUp($import_test_views = TRUE): void {
      parent::setUp($import_test_views);

--- a/core/modules/views/tests/src/Functional/Plugin/ExposedFormTest.php
 +++ b/core/modules/views/tests/src/Functional/Plugin/ExposedFormTest.php
 @@ -38,6 +38,9 @@ class ExposedFormTest extends ViewTestBase {
     */
    protected $defaultTheme = 'classy';
- 
+
 +  /**
-+   *
++   * {@inheritdoc}
 +   */
    protected function setUp($import_test_views = TRUE): void {
      parent::setUp($import_test_views);

-+   *   The Behat session object;.
++   *   The Behat session object.

-    // Loops trough all the option groups
 +    // Loops trough all the option groups.

other than this patch is looks good me.

@Hardik_Patel_12,

I have checked interdiff, which was added by you and checked your comment #14, I think no need to update last patch #13. Because there are removed extra space and added Doc comment, which was empty.

Patch #13 is looks good for me and we can move for RTBC+1.

+++ b/core/modules/field/tests/src/Functional/EntityReference/EntityReferenceAdminTest.php
@@ -355,7 +355,7 @@ public function testMultipleTargetBundles() {
    *
    * @param string $target_type
-   *   The name of the target type
+   *   The name of the target type.
    * @param string[] $bundles
    *   A list of bundle IDs. Defaults to [].

We should remove the unrelated changes from this patch and handle them in a separate issue.

Also, we should add a trigger_error() to the deprecated buildXPathQuery() methods, either here or in a follow-up:

  protected function buildXPathQuery($xpath, array $args = []) {
    return $this->assertSession()->buildXPathQuery($xpath, $args);
  }

Working on it.

Patch at #13 is now failed to apply , re-rolling the patch and removing unrelated changes and deprecated with @trigger_error is already there. Kindly review a new patch.

@mondrake no I think it was me who was missing something...

1. +++ b/core/modules/views/tests/src/Functional/Handler/FieldWebTest.php
   @@ -47,6 +47,9 @@ class FieldWebTest extends ViewTestBase {
   +  /**
   +   * ¶
   +   */
   

   {@inheritdoc}

2. +++ b/core/modules/views/tests/src/Functional/Plugin/ExposedFormTest.php
   @@ -38,6 +38,9 @@ class ExposedFormTest extends ViewTestBase {
   +  /**
   +   * ¶
   +   */
   

   Same

The re-roll in #20 does not look right, Did again based on #13.

1. +++ b/core/tests/Drupal/FunctionalTests/BrowserTestBaseTest.php
   @@ -817,4 +817,14 @@ public function testDeprecationHeaders() {
   +  /**
   +   * Tests legacy buildXPathQuery().
   +   *
   +   * @group legacy
   +   * @expectedDeprecation AssertLegacyTrait::buildXPathQuery() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->buildXPathQuery() instead. See https://www.drupal.org/node/3129738
   +   */
   +  public function testBuildXPathQuery() {
   +    $this->buildXPathQuery('\\html');
   +  }
   +
   

   The test was lost in the middle.

2. +++ b/core/tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php
   @@ -205,7 +205,6 @@ public static function getSkippedDeprecations() {
   -      'AssertLegacyTrait::buildXPathQuery() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->buildXPathQuery() instead. See https://www.drupal.org/node/3129738',
   

   Lost the removal in the middle.

3. A lot of changes unexpected / out of scope

Addressing #24

Committed c114930 and pushed to 9.1.x. Thanks!

I't be good to have a version of this to backport to 9.0.x and 8.9.x to keep the tests aligned. Minus the change to the skipped deprecations and the test of deprecation message.

@alexpott I am working on to backport to 9.0.x and 8.9.x.I will upload the patch soon after test.

@alexpott patch has been re-rolled for 8.9.x and 9.0.x .

@mondrake point #33 has been noticed for re-rolled patch. I have removed testBuildXPathQuery() from these patches.
Please review these patches.
Could you please conform we need to be remove this in 9.1.x

Thanks
pavnish

@mondrake thanks for the review.
I have changed the patch as suggested by you could you please review.
Thanks for the help :).

@mondrake It was strange that the Drupal CI failed the patch first time. After that i again schedule for the retest then it's showing pass :)
Could you please review again and move this to expected state.