Problem/Motivation

As title

Proposed resolution

Recommended regex for searching: assert\w+\(.+instanceof.+\)

Example:

-    $this->assertTrue($property instanceof StringInterface, 'Got the right wrapper fo the page.front property.');
+    $this->assertInstanceOf(StringInterface::class, $property, 'Got the right wrapper fo the page.front property.');

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mero.S created an issue. See original summary.

mero.S’s picture

mero.S’s picture

Assigned: mero.S » Unassigned
Status: Needs work » Needs review

  • borisson_ committed 6af46e7 on 8.x-1.x authored by mero.S
    Issue #3139032 by mero.S: Replace assert* involving an instanceof...
borisson_’s picture

Status: Needs review » Fixed

Committed and pushed, thanks.,

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.