Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
When adding a computed base field to the commerce_product_variation
entity type, for example in order to use it as a Product Attribute field, \Drupal\commerce\CommerceEntityViewsData::getViewsData()
errors out because computed fields don't have a schema.
Proposed resolution
Skip generating views data for computed fields.
Remaining tasks
Review.
User interface changes
Nope.
API changes
Nope.
Data model changes
Nope.
Release notes snippet
Nope.
Comment | File | Size | Author |
---|---|---|---|
#6 | 3138565-commerce-2.x-2.19-do-not-commit.patch | 1.13 KB | jsacksick |
#3 | 3138565-commerce-2.x-2.17-do-not-commit.patch | 831 bytes | amateescu |
#2 | 3138565.patch | 885 bytes | amateescu |
|
Comments
Comment #2
amateescu CreditAttribution: amateescu as a volunteer commentedHere's a patch for this.
Comment #3
amateescu CreditAttribution: amateescu as a volunteer commentedAlso attaching a patch for the current stable Commerce release, so it can be used in projects that don't use the -dev version.
Comment #4
amateescu CreditAttribution: amateescu as a volunteer commentedComment #5
jsacksick CreditAttribution: jsacksick at Centarro commentedYour fix ls the appropriate one :), thanks, committed!
Comment #6
jsacksick CreditAttribution: jsacksick at Centarro commentedAttaching a patch that should apply to 2.19.
Comment #7
bradjones1FYI this issue is missing commit credit.
Comment #8
jsacksick CreditAttribution: jsacksick at Centarro commentedNot sure why, the commit author was properly set to Andrei.
https://git.drupalcode.org/project/commerce/-/commit/0efa05b162a6d54f526...