Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
go to /batch and you'll get a 403 and a php warning:
Cannot modify header information - headers already sent by (output started at /var/www/html/includes/common.inc)
Comments
Comment #2
mikeytown2 CreditAttribution: mikeytown2 commentedComment #3
jungle@mikeytown2, thanks for filing this.
Applying IS template, tagging "Needs tests" and "Bug Smash Initiative".
Comment #4
Kristen PolThanks for the issue and patch. I've tested as follows:
/batch
/batch
Moving back to "needs work" for tests.
Comment #5
awset CreditAttribution: awset at Salsa Digital commentedHi All,
thanks for the good work.
Adding a test for the patch provided by mikeytown2.
I also added the interdiff for the same.
this need a review.
thanks
Comment #6
poker10 CreditAttribution: poker10 at ActivIT s.r.o. commentedThanks @awangsetyawan for the test. I have tweaked it a little bit to remove the need of the new method (assertNoLogMessage()), so we can keep the code cleaner.
Adding test-only patch and regular patch to see if testbot will be happy. If yes, I think this can be set as RTBC, as the patch is trivial and it is confirmed also by manual testing.
Comment #8
poker10 CreditAttribution: poker10 at ActivIT s.r.o. commentedAs I have mentioned in #6, I am setting this as RTBC, because patch was unchanged and confirmed that is is working before. Tests are passing / failing as expected too.
Comment #9
Kristen Pol@poker10 Thanks for the updated patch. Please create an interdiff when making changes:
https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa...
Since you updated the patch, you can't mark this RTBC so moving back to Needs review.
Comment #10
poker10 CreditAttribution: poker10 at ActivIT s.r.o. commentedThanks @Kristen Pol for pointing this out. It seems like I made an unintentional mistake here - I did not mean to RTBC my own patch. Reuploading the patch from #6 again with an interdiff, which was missing here.
Comment #11
Kristen PolThanks @poker10 :)
Comment #13
mcdruidThere are several other places in core where we call
drupal_exit()
afterdrupal_access_denied()
for example:Patch looks good, thanks!
Comment #14
Kristen PolWhat’s RTBM? Curious:)
Comment #15
mcdruidRTBM is Ready To Be Merged :) so approved by one maintainer for another to commit.
It's mentioned in #3093258: [policy, no patch] Proposed Drupal 7 contributor / maintainer workflow which never really got beyond a draft, but we've been following it pretty much for a while in D7.
Comment #16
Kristen PolOh! Very cool. I wasn’t familiar. Thanks:)
Comment #18
poker10 CreditAttribution: poker10 at ActivIT s.r.o. commentedThanks everyone who contributed!