Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Follow up to #3114617-40: Properly deprecate methods in Drupal\FunctionalTests\AssertLegacyTrait and Drupal\KernelTests\AssertLegacyTrait, while still keeping deprecations silenced. Change the link from the issue to the CR.
Proposed resolution
- * @expectedDeprecation AssertLegacyTrait::getAllOptions() is deprecated in drupal:8.5.0 and is removed from drupal:10.0.0. Use $element->findAll('xpath', 'option') instead. See http://drupal.org/node/2735045
+ * @expectedDeprecation AssertLegacyTrait::getAllOptions() is deprecated in drupal:8.5.0 and is removed from drupal:10.0.0. Use $element->findAll('xpath', 'option') instead. See https://www.drupal.org/node/3129738Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3137455-4.patch | 7.34 KB | sja112 |
Comments
Comment #2
sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commentedComment #3
sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commentedComment #4
sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commentedCreated the patch add/update the CR link in the deprecated code messages.
Comment #5
mondrakeComment #6
mondrakeComment #7
mondrakeThanks
Comment #8
longwaveImproving the title a bit.
Is this the only cases where the message points to an issue instead of a CR? Can we check this automatically somehow?
Comment #9
mondrakeComment #13
xjmThanks for splitting this out. Saving credits for work from the other issue as well.
Reviewed locally with
git diff --color-wordsand confirmed that this only changes node IDs (and in some cases, for the same URLs, adds the canonicalhttps://orwww. There are three URLs replaced with https://www.drupal.org/node/3129738:Confirmed that there are no remaining references to the above in core as well.
#8 is a good question. I think it's good to keep the scope here limited to this one CR, since it is relevant for so many deprecations, but it should be straightforward-ish to write a script that generates a list of CRs in deprecations in the codebase, curls down those URLs, and parses the source for what kind of node it is. (I'd put limits on such a script when testing it to not get on d.o's naughty list.) Tagging "Needs followup" to check for that. We should at least fix it in 9.1.x if not the older branches.
Committed to 9.1.x, and cherry-picked to 9.0.x and 8.9.x since these links are wrong there too, and it's not new deprecations, just correcting existing ones. I didn't backport it to 8.8.x in case there were specific checks against the URLs in the deprecation messages in contrib.
Thanks!
Comment #14
jungleAdding the "Deprecated assertions" tag to add this into the kanban board https://contribkanban.com/board/Deprecatedassertions
Setting back NW for Needs followup
Comment #15
longwaveOpened #3142460: Ensure all deprecation messages point to a change record