The UpgradeStatusForm::__construct() method should use StateInterface instead of State class.

CommentFileSizeAuthor
#2 upgrade_status-state-interface-3136155-2.patch1.69 KBDaniel Kulbe
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Daniel Kulbe created an issue. See original summary.

Daniel Kulbe’s picture

Daniel Kulbe
he/him
Primary language German
Location Berlin
CreditAttribution: Daniel Kulbe as a volunteer commented
FileSize
upgrade_status-state-interface-3136155-2.patch1.69 KB

Patch attached.

Daniel Kulbe’s picture

Daniel Kulbe
he/him
Primary language German
Location Berlin
CreditAttribution: Daniel Kulbe as a volunteer commented
Title: UpgradeStatusForm not compatible with devel » UpgradeStatusForm not compatible with webprofiler (devel)
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Active » Needs review

That's a really good point. Don't know how did this happen, sorry.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Title: UpgradeStatusForm not compatible with webprofiler (devel) » UpgradeStatusForm should type-hint to StateInterface, not State; fix compatibility with webprofiler (devel)

  • Gábor Hojtsy committed f69fc0f on 8.x-2.x 
    Issue #3136155 by Daniel Kulbe: UpgradeStatusForm should type-hint to...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.