Problem/Motivation

As title.

Proposed resolution

For example:

-    $this->assertTrue(array_key_exists("data-entity-uuid", $htmlRestrictions['allowed']['a']));
+    $this->assertArrayHasKey("data-entity-uuid", $htmlRestrictions['allowed']['a']);

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 linkit-replace_array_key_exists_with_assertArrayHasKey-3135857-2.patch1.46 KBmero.S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mero.S created an issue. See original summary.

mero.S’s picture

mero.S CreditAttribution: mero.S as a volunteer and at AnyforSoft for AnyforSoft commented
FileSize
linkit-replace_array_key_exists_with_assertArrayHasKey-3135857-2.patch1.46 KB
mero.S’s picture

mero.S CreditAttribution: mero.S as a volunteer and at AnyforSoft for AnyforSoft commented
Assigned: mero.S » Unassigned
Status: Needs work » Needs review
novchuk.v’s picture

novchuk.v CreditAttribution: novchuk.v commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

+1 for RTBC. These assertions look correct to me, and are more readable.

  • anon committed 2f870ec on 8.x-5.x authored by mero.S 
    Issue #3135857 by mero.S, anon: Replace assertions involving calls to...
anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented
Status: Reviewed & tested by the community » Fixed

Thanks for patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.