Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
@shaal raised this reviewing #3133017: Add rector coverage info to errors that we should group errors by type. This would even allow us to have instructions / descriptions for what each type means right at the list, rather than somewhere else. It would allow us to funnel people much easier into using rector as well. If we remove the repeating type column that would also allow us to have a more readable output. So let's see what we can do for that.
Comment | File | Size | Author |
---|---|---|---|
#18 | Screenshot 2020-05-08 at 11.25.59.png | 105.37 KB | Gábor Hojtsy |
#12 | interdiff.txt | 901 bytes | Gábor Hojtsy |
#12 | 3134167-12.patch | 17.66 KB | Gábor Hojtsy |
#10 | interdiff.txt | 8.1 KB | Gábor Hojtsy |
#10 | 3134167-10.patch | 16.78 KB | Gábor Hojtsy |
Comments
Comment #2
Gábor HojtsyHere is a start. I don't like the pieces of bland text at the top, they are not very well structured. Probably need a definition list type of setup or somesuch. I am not a designer, just trying to do my best :D suggestions welcome.
BEFORE:
AFTER:
Note that we are funeling people into being rector users at the automatic fix category and rector contributors at the manual fix category ;)
Comment #4
Kristen PolI'll take a look even though it's not done yet.
Comment #5
Gábor HojtsyWrong category for uncategorized :D Haha.
We may want to change the color / image of the "Ignore" category to not be similar to the category above it :D Also an exclamation mark in a triangle for stuff to ignore does not match well for what we mean there.
Comment #7
Kristen PolI quickly scanned the code and only noticed some nitpicks. As for the UI, I didn't test it because STM is down right now but, looking at the images you provided, 1) this is great (love the grouping :), 2) some of the leading info could be tweaked a little but these are nitpicks as well (see below).
Formatting:
Nitpick: Extra space at end of line.
Nitpick: Capitalize "upgrade status"?
Nitpick: Extra space at end of line.
Nitpick: Double quotes could be single quotes.
Wording:
Nitpick: Based on the structure, it's unclear if "to generate patches" is meant to be for "Upgrade Rector" only or for both "drupal-rector" and "Update Rector" since "drupal-rector" already has a "to fix issues automatically" in the link. If it's only for "Update Rector", I would move "to generate patches" within the link.
Nitpick: "to provide one" seems unclear. How about "to provide coverage"?
Nitpick: Change "Error" to "Errors" or "Error(s)" or restructure to use "These" like in some other text.
Comment #8
Gábor HojtsyFixed all of those, thanks @Kristen Pol!
Also fixed the explanation for the "fix later" category since its actually different for contrib projects vs. custom projects.
Comment #10
Gábor HojtsyThen went on to add the capability to alter the result display, so upgrade_rector can change it. This results in this feature:
https://www.drupal.org/files/issues/2020-05-07/Screen%20Recording%202020...
Still need to fix tests / the HTML export but otherwise should be fine.
Comment #12
Gábor HojtsyFix export which should make those tests pass too (they pass locally) :) Fixed it visually too.
Comment #13
Gábor HojtsyCommitted a upgrade_rector update to integrate with this expecting this landing :D https://git.drupalcode.org/project/upgrade_rector/-/commit/e06d65cd38034...
Comment #15
Gábor HojtsyLanded this. There is probably still more optimisations that could happen. But we can do them in future updates.
Comment #16
Kristen PolWoot! Thanks! Took a quick look and...
Typo to fix later: "differen guidance" => "different guidance".
Comment #18
Gábor HojtsyThanks, fixed that and also added a unique icon to the "fix later" category. Also no coloring there.
Comment #19
Kristen PolLooks great!