FILE: src/Plugin/Condition/DateLimit.php
--------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------
   3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
  21 | ERROR | [x] Additional blank lines found at end of doc comment
 103 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2
     |       |     spaces
 120 | ERROR | [x] Expected 1 blank line after function; 0 found
 121 | ERROR | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------

Time: 105ms; Memory: 10MB

Comments

ramu_bharu created an issue. See original summary.

dmezquia’s picture

Thanks for the feedback @ramu_bharu , soon I will be working on this module and this will be corrected. for the next release.

ramu_bharu’s picture

StatusFileSize
new4.59 KB
dmezquia’s picture

Status: Needs work » Needs review
longwave’s picture

Status: Needs review » Needs work

Patch no longer applies.

longwave’s picture

Version: 8.x-1.x-dev » 2.0.0
sourabhjain’s picture

Status: Needs work » Needs review
StatusFileSize
new1.07 KB

Resolved the PHPCS issue. Could you please review it.

hmendes’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new38.27 KB

The current phpcs errors are different from the ones originally reported (print attached), updating the IS.
THe patch applies successfully and fixes all problems. Changing this to RTBC.

longwave’s picture

Status: Reviewed & tested by the community » Fixed

Committed, thanks!

  • longwave committed e7ebfe62 on 1.0.x authored by sourabhjain
    Issue #3133943 by ramu_bharu, sourabhjain, hmendes: Fix code standards...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.