As a follow up of https://www.drupal.org/project/shield/issues/2953625, we should add more tests to cover the basic features of shield.

Suggestion:
- Enable checkbox
- Auth message
- Shield credential provider

CommentFileSizeAuthor
#4 shield-tests-3133349-3.patch3.5 KBvbouchet
#2 shield-tests-3133349-2.patch2.82 KBvbouchet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vbouchet created an issue. See original summary.

vbouchet’s picture

vbouchet
Location Toulouse
CreditAttribution: vbouchet at Acquia commented
Status: Active » Needs review
FileSize
shield-tests-3133349-2.patch2.82 KB

Please find a patch which extends the test coverage.

Status: Needs review » Needs work

The last submitted patch, 2: shield-tests-3133349-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vbouchet’s picture

vbouchet
Location Toulouse
CreditAttribution: vbouchet at Acquia commented
FileSize
shield-tests-3133349-3.patch3.5 KB

Existing test is failing because I was enabling/configuring shield in the setup() method. I updated the setup() so it prepare everything but does not enable shield feature. I updated my test cases so it does not assume shield feature is enabled.

Updated patch.

vbouchet’s picture

vbouchet
Location Toulouse
CreditAttribution: vbouchet at Acquia commented
Status: Needs work » Needs review

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at Geeks4Change, MachbarMacher commented
Status: Needs review » Fixed

Thanks, that's brilliant. Can you estimate what parts are missing in coverage?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.