Problem/Motivation

If you change the attribute field on a product variation to use an Entity Reference View to filter to options there is a fatal error in commerce_product_field_views_data_alter() because $handler_settings['target_bundles'] is not set.

Proposed resolution

Check that the reference field is using the default handler before altering

if ($field->getSetting('handler') == 'default:commerce_product_attribute_value')

Original report by @orangeicebear

i got this Warning

Warning: array_values() expects parameter 1 to be array, null given in commerce_product_field_views_data_alter() (line 33 of modules/contrib/commerce/modules/product/commerce_product.views.inc).
Warning: reset() expects parameter 1 to be array, null given in commerce_product_field_views_data_alter() (line 34 of modules/contrib/commerce/modules/product/commerce_product.views.inc).

CommentFileSizeAuthor
#10 3133003-10.patch689 bytesjsacksick
#9 3133003-9.patch1.71 KBdwkitchen
#7 3133003-7.patch88.07 KBnarendra.rajwar27
#7 interdiff_5-7.txt920 bytesnarendra.rajwar27
#6 interdiff_5-6.txt547 bytesnarendra.rajwar27
#6 3133003-6.patch88.28 KBnarendra.rajwar27
#5 3133003-5.patch87.14 KBnarendra.rajwar27
#3 fix-warning-3133003-3.patch666 bytescobenash
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

orangeicebear created an issue. See original summary.

cobenash’s picture

cobenash
Location Taipei
CreditAttribution: cobenash commented

Confirmed error.

cobenash’s picture

cobenash
Location Taipei
CreditAttribution: cobenash commented
FileSize
fix-warning-3133003-3.patch666 bytes

I think the problem was caused because I deleted the default product type.

But I think this is a proper move that the user may do, so I create a patch to fix the warning.

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » narendra.rajwar27
narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Active » Needs review
FileSize
3133003-5.patch87.14 KB

Fix for the failed test cases.

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3133003-6.patch88.28 KB
interdiff_5-6.txt547 bytes
narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs review » Needs work
FileSize
interdiff_5-7.txt920 bytes
3133003-7.patch88.07 KB

Patch issue in #6, adding updated patch after correction.

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Assigned: narendra.rajwar27 » Unassigned
Status: Needs work » Needs review
dwkitchen’s picture

dwkitchen CreditAttribution: dwkitchen at Centarro commented
Title: commerce_product.views.inc » commerce_product_field_views_data_alter() assumes the default handler is being used
Version: 8.x-2.17 » 8.x-2.x-dev
Issue summary: View changes
FileSize
3133003-9.patch1.71 KB

Updated the cause of the issue and provided patch

jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro commented
FileSize
3133003-10.patch689 bytes

I think checking if the "target_bundles" setting isn't empty is a better option.

That still leaves the opportunity to define another entity reference selection handler, that isn't the default one and that still uses the same setting.

@dwkitchen: let me know if this approach still works for your usecase.

dwkitchen’s picture

dwkitchen CreditAttribution: dwkitchen at Centarro commented
Status: Needs review » Reviewed & tested by the community

Yep good idea, resolves issue

  • jsacksick committed 5a792d6 on 8.x-2.x 
    Issue #3133003 by narendra.rajwar27, cobenash, dwkitchen, jsacksick,...

  • jsacksick committed 36dea32 on 3.0.x 
    Issue #3133003 by narendra.rajwar27, cobenash, dwkitchen, jsacksick,...
jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro commented
Status: Reviewed & tested by the community » Fixed

Committed! @dwkitchen: Thanks for confirming that the fix works as expected!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.