FacetSourcePluginManager doesn't specify caching for its definitions. So every request that \Drupal\facets\FacetManager\DefaultFacetManager::alterQuery runs for each facet, it does at least one disk scan for annotation plugins.

CommentFileSizeAuthor
#4 Screen Shot 2020-11-17 at 11.13.20 PM.png113.79 KBmglaman
#4 Screen Shot 2020-11-17 at 11.13.15 PM.png110.47 KBmglaman
#4 Screen Shot 2020-11-17 at 11.13.11 PM.png103.32 KBmglaman
#3 3132752-3.patch1.35 KBmglaman
#2 3132752-2.patch721 bytesmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for E.C. Barton & Co commented
Status: Active » Needs review
FileSize
3132752-2.patch721 bytes

Adds caching.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for E.C. Barton & Co commented
FileSize
3132752-3.patch1.35 KB

Neither does QueryTypePluginManager.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Bluehorn Digital commented
FileSize
Screen Shot 2020-11-17 at 11.13.11 PM.png103.32 KB
Screen Shot 2020-11-17 at 11.13.15 PM.png110.47 KB
Screen Shot 2020-11-17 at 11.13.20 PM.png113.79 KB

This is still a thing.

  • borisson_ committed d477de9 on 8.x-1.x authored by mglaman 
    Issue #3132752 by mglaman: FacetSourcePluginManager does not specify...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Needs review » Fixed

Fixed. Thanks Matt!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.