Just a minor. Composer validate throws a warning.

martin@martin-XPS-13-9370 /var/www/html/brown.localhost/web/modules/contrib/dropzonejs (8.x-2.x=) $ composer validate
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
License "GPL-2.0+" is a deprecated SPDX license identifier, use "GPL-2.0-or-later" instead
CommentFileSizeAuthor
#12 interdiff-9-12.txt411 bytesjungle
#12 3132660-12.patch4.42 KBjungle
#9 interdiff-7-9.txt854 bytesjungle
#9 3132660-9.patch4.43 KBjungle
#7 3132660-7.patch4.44 KBjungle
#5 dropzonejs-deprecated_license_identifier-3132660-5.patch654 byteslolandese
#2 dropzonejs-deprecated_license_identifier-3132660-2.patch391 byteslolandese
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lolandese created an issue. See original summary.

lolandese’s picture

lolandese CreditAttribution: lolandese at Cognizant Technology Solutions commented
Status: Active » Needs review
FileSize
dropzonejs-deprecated_license_identifier-3132660-2.patch391 bytes

After applying the attached patch it is solved:

martin@martin-XPS-13-9370 /var/www/html/brown.localhost/web/modules/contrib/dropzonejs (8.x-2.x=) $ composer validate
./composer.json is valid

Status: Needs review » Needs work

The last submitted patch, 2: dropzonejs-deprecated_license_identifier-3132660-2.patch, failed testing. View results

lolandese’s picture

lolandese CreditAttribution: lolandese at Cognizant Technology Solutions commented

It seems unlikely the test is failing because of this patch. Probably something else.

lolandese’s picture

lolandese CreditAttribution: lolandese at Cognizant Technology Solutions commented
Status: Needs work » Needs review
FileSize
dropzonejs-deprecated_license_identifier-3132660-5.patch654 bytes

The test might fail because of dependencies on other modules are missing in the composer.json. This only lets the test fail when the compser.json is changed. See https://www.drupal.org/project/pathauto/issues/3131057#comment-13577096

Attaching new patch, just to try.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs followup

#2 is RTBC to me.

+++ b/composer.json
@@ -34,7 +34,9 @@
+    "drupal/entity_browser": "*"

Adding it to the require-dev section makes sense to me, not the require section. Would you file a new issue for this?

Thanks!

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Title: License "GPL-2.0+" is a deprecated SPDX license identifier » Update composer.json and README.md
Priority: Minor » Normal
Status: Needs work » Needs review
Issue tags: -Needs followup
FileSize
3132660-7.patch4.44 KB

Well, let's rescope this to update composer.json and README.

Proposed changes to composer.json

  • Update license identifier
  • Update maintainers
  • Update indentation -- 4 spaces instead of 2.
  • Add drupal/entity_browser to require-dev section
  • Update IRC. to slack

Proposed changes to README.md

  • Drupal 8 integration to Drupal integration as 8.2.x is Drupal 9 compatible
  • Update maintainers
  • Update Drupal 8 specific link
  • Update IRC. to slack
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Needs work 
+++ b/README.md
@@ -25,11 +25,12 @@ You will now have a dropzonejs element at your disposal.
+ - **#drupal-media**：http://drupal.slack.com

+++ b/composer.json
@@ -1,41 +1,49 @@
+        "#drupal-media": "http://drupal.slack.com/",

#drupal-media is inactive compared with #media, so let's change it to #media. 68 members vs 533 members ATM.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs work » Needs review
FileSize
3132660-9.patch4.43 KB
interdiff-7-9.txt854 bytes

Addressing #8

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde as a volunteer and at Taoti Creative commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.
Just a note for anyone else reviewing, your browser may say silly things instead of**: and think it is a malformed Unicode char - but looking at it in a real editor and it is fine.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented

+ - **#media**：http://drupal.slack.com

TRUE, i will update the patch! Thanks @NickDickinsonWilde for reviewing!

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
FileSize
3132660-12.patch4.42 KB
interdiff-9-12.txt411 bytes

Just a note for anyone else reviewing, your browser may say silly things instead of**: and think it is a malformed Unicode char

It's a colon in Chinese. Fixed. my bad.

  • jungle committed 4401cf2 on 8.x-2.x 
    Issue #3132660 by jungle, lolandese, NickDickinsonWilde: Update composer...
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.