Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Attached patch converts includes/batch.inc to DBTNG. It should have no other effect. To test, run, um, some unit test. :-)
Comment | File | Size | Author |
---|---|---|---|
#4 | 313152.patch | 1.71 KB | RobLoach |
dbtng-batch.patch | 1.75 KB | Crell | |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedConsistent coding:
Should we strive to be consistent with line breaks and indentation for the use of ->?
I.E.: Should
Change to:
to match:
Comment #2
Crell CreditAttribution: Crell commentedIf the query is short and doesn't cross the 80 character boundary, there's no need to break it across multiple lines. The first query doesn't. The second query does. I defer to webchick on that convention, however.
Comment #3
webchickI prefer consistency, so putting all of them on their own lines is better from my perspective. Also, it makes diffs more meaningful if we ever change the query properties.
Comment #4
RobLoachThe only change I made is the whitespace change suggested at #1. In addition to that, tests are passing, so setting this to RTBC.
Should we use db_select here?
Comment #5
Crell CreditAttribution: Crell commented@Rob: Nope, because the query structure itself is not dynamic. It's just easier to read if we put the array in long form, like FAPI and menu items. db_select() should only be used when the structure of the query itself needs to change at runtime.
Thanks for the patch fix!
Comment #6
webchickAwesome. Changes look great, and ran through a few SimpleTests with no problems. Committed. Thanks!
Comment #7
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #8
Crell CreditAttribution: Crell commentedTagging.