Problem/Motivation

9.1.x-dev

  1. 9.1.x-dev test with PHP 7.3.x-dev & MySQL 5.7, See https://www.drupal.org/pift-ci-job/1659673
  2. 9.1.x-dev test with PHP 7.4.x-dev & MySQL 5.7, See https://www.drupal.org/pift-ci-job/1659676

9.0.x-dev

  1. 9.0.x-dev test with PHP 7.3.x-dev & MySQL 5.7, See https://www.drupal.org/pift-ci-job/1659672

1) Drupal\Tests\media\Functional\ResourceFetcherTest::testFetchResource with data set "XML resource" ('video_collegehumor.xml', 'CollegeHumor', 'Let's Not Get a Drink Sometime')
Drupal\media\OEmbed\ResourceException: Resource version must be '1.0'

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3130427-2.patch593 bytesjungle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Active » Needs review
FileSize
3130427-2.patch593 bytes 
<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<oembed>
	<version>1.0</version>
	<type>link</type>
	<author_name>Cal Henderson</author_name>
	<author_url>http://iamcal.com/</author_url>
	<cache_age>86400</cache_age>
	<provider_name>iamcal.com</provider_name>
	<provider_url>http://iamcal.com/</provider_url>
</oembed>

Example from https://oembed.com/#section5

The culprit might be core/modules/media/tests/fixtures/oembed/video_collegehumor.xml

-  <version type="float">1.0</version>
+  <version>1.0</version>
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

The oEmbed spec at https://oembed.com/ does not mention a type attribute for the version tag and in fact says it can only be 1.0 which is already obviously a float. Therefore I think this change is correct to make whether it has any effect on the tests or not.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Title: Fix upstream failing tests of 9.x » Fix upstream failing tests

Thanks @longwave for reviewing! Changing the title a little bit as it could be backported to 8.x

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Title: Fix upstream failing tests » Fix upstream failing tests involving in oEmbed
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Priority: Normal » Major

Raising the priority

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 9.1.x-dev » 8.8.x-dev
Priority: Major » Critical

We'll want to backport this all the way to 8.8 I think.

  • catch committed 79b7e02 on 9.1.x 
    Issue #3130427 by jungle, longwave, xjm: Fix upstream failing tests...

  • catch committed 3590225 on 9.0.x 
    Issue #3130427 by jungle, longwave, xjm: Fix upstream failing tests...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.1.x and cherry-picked back to 8.8.x, thanks!

  • catch committed 1a1240b on 8.9.x 
    Issue #3130427 by jungle, longwave, xjm: Fix upstream failing tests...

  • catch committed e41613f on 8.8.x 
    Issue #3130427 by jungle, longwave, xjm: Fix upstream failing tests...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.