Problem/Motivation

As title

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3128575-4.patch6.88 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Title: Replace assertIdentical(*, is_null() with assertNotNull/assertNull » Replace assertIdentical(*, is_null()) with assertNotNull()/assertNull()
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Title: Replace assertIdentical(*, is_null()) with assertNotNull()/assertNull() » Replace assert*(*, is_null()) with assertNotNull()/assertNull()

Giving a larger scope

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3128575-4.patch6.88 KB
daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

All code changes look good to me.
I have search the code base for "is_null(" and I could not find any more test assertions.
For me it is RTBC.

KapilV’s picture

KapilV CreditAttribution: KapilV as a volunteer and at OpenSense Labs commented
Issue tags: +drupal core
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Issue tags: -drupal core

Tagging drupal core is unnecessary

  • catch committed bcec845 on 9.1.x 
    Issue #3128575 by longwave, jungle, daffie: Replace assert*(*, is_null...

  • catch committed af05690 on 9.0.x 
    Issue #3128575 by longwave, jungle, daffie: Replace assert*(*, is_null...

  • catch committed c0246d1 on 8.9.x 
    Issue #3128575 by longwave, jungle, daffie: Replace assert*(*, is_null...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.1.x, cherry-picked back to 8.9.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.