Tests currently fail on Drupal 9 because some of ours are missing the $defaultTheme property; see https://www.drupal.org/pift-ci-job/1652024. Let's get this fixed up; it should be a fully backwards-compatible change in tests only.

CommentFileSizeAuthor
#2 3128394-2.patch1.51 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review
FileSize
3128394-2.patch1.51 KB

Patch time!

  • phenaproxima committed 2c957cb on 8.x-1.x 
    Issue #3128394 by phenaproxima: Fix tests on Drupal 9
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Fixed

OK...I know it's bad etiquette to commit one's own patch, but these are only changing tests, and in a backwards-compatible way. Fixing the tests on D9 allows us to get more actual work done, so I made the executive decision to continue. Committed and pushed to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.