Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Tests do not pass on Drupal 9: https://www.drupal.org/pift-ci-job/1652080. Read 'em and and weep. The solution's pretty straightforward -- get those tests passing on D9, and keep them passing on D8.
Due to a BC break in core between 8.7 and 8.8, this is going to necessitate bumping the minimum supported version of core to 8.8.
Comment | File | Size | Author |
---|---|---|---|
#11 | interdiff-3128339-9-11.txt | 518 bytes | phenaproxima |
#11 | 3128339-11.patch | 7.9 KB | phenaproxima |
#5 | 3128339-5.patch | 3.31 KB | phenaproxima |
#9 | interdiff-3128339-7-9.txt | 1.23 KB | phenaproxima |
#3 | interdiff-3128339-2-3.txt | 1.23 KB | phenaproxima |
Comments
Comment #2
phenaproximaAnd, patch.
Comment #3
phenaproximaOkay, let's see if this fixes the remaining failures.
I had to raise the minimum core version for ctools_views to 8.8, because \Drupal\ctools_views\Plugin\Display\Block::__construct() passes the entity type manager to the parent constructor. The parent constructor, however, changed between 8.7 and 8.8 -- in 8.7 it expects the entity manager, and in 8.8 it expects the entity type manager. That's technically a BC break in core, but it's a done deal at this point we just have to deal with it. We could try to hack around it in some way, but given that 8.7 is on its last legs, just requiring 8.8 seemed like the cleaner solution here.
Comment #5
phenaproximaWell, at least they failed consistently.
Comment #6
japerryNeed to add 8.8 to the info and composer for the base ctools module.
Comment #7
phenaproximaFair enough. Mixing version requirements has definitely caused some weirdness, like in #3127358: ctools block incorrectly specifies a version, so it makes sense to just bump all the modules to 8.8.
Comment #8
phenaproximaComment #9
phenaproximaGood thing I did a
find . -name '*.info.yml'
; looks like I missed a few spots. 😬Comment #11
phenaproximaHah, okay. I forgot that only modules in the Testing package can omit core and core_version_requirement.
Comment #13
japerryLooks good. Committed.