Tests do not pass on Drupal 9: https://www.drupal.org/pift-ci-job/1652080. Read 'em and and weep. The solution's pretty straightforward -- get those tests passing on D9, and keep them passing on D8.

Due to a BC break in core between 8.7 and 8.8, this is going to necessitate bumping the minimum supported version of core to 8.8.

CommentFileSizeAuthor
#11 interdiff-3128339-9-11.txt518 bytesphenaproxima
#11 3128339-11.patch7.9 KBphenaproxima
#5 3128339-5.patch3.31 KBphenaproxima
#9 interdiff-3128339-7-9.txt1.23 KBphenaproxima
#3 interdiff-3128339-2-3.txt1.23 KBphenaproxima
#3 3128339-3.patch3.29 KBphenaproxima
#7 3128339-7.patch6.04 KBphenaproxima
#9 3128339-9.patch7.84 KBphenaproxima
#2 3128339-2.patch1.85 KBphenaproxima
#5 interdiff-3128339-3-5.txt368 bytesphenaproxima
#7 interdiff-3128339-5-7.txt2.1 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review
FileSize
3128339-2.patch1.85 KB

And, patch.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
3128339-3.patch3.29 KB
interdiff-3128339-2-3.txt1.23 KB

Okay, let's see if this fixes the remaining failures.

I had to raise the minimum core version for ctools_views to 8.8, because \Drupal\ctools_views\Plugin\Display\Block::__construct() passes the entity type manager to the parent constructor. The parent constructor, however, changed between 8.7 and 8.8 -- in 8.7 it expects the entity manager, and in 8.8 it expects the entity type manager. That's technically a BC break in core, but it's a done deal at this point we just have to deal with it. We could try to hack around it in some way, but given that 8.7 is on its last legs, just requiring 8.8 seemed like the cleaner solution here.

Status: Needs review » Needs work

The last submitted patch, 3: 3128339-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
3128339-5.patch3.31 KB
interdiff-3128339-3-5.txt368 bytes

Well, at least they failed consistently.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Needs review » Needs work

Need to add 8.8 to the info and composer for the base ctools module.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
3128339-7.patch6.04 KB
interdiff-3128339-5-7.txt2.1 KB

Fair enough. Mixing version requirements has definitely caused some weirdness, like in #3127358: ctools block incorrectly specifies a version, so it makes sense to just bump all the modules to 8.8.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Title: Fix tests on Drupal 9 » Fix tests on Drupal 9 and drop support for 8.7
Issue summary: View changes
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
3128339-9.patch7.84 KB
interdiff-3128339-7-9.txt1.23 KB

Good thing I did a find . -name '*.info.yml'; looks like I missed a few spots. 😬

Status: Needs review » Needs work

The last submitted patch, 9: 3128339-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
3128339-11.patch7.9 KB
interdiff-3128339-9-11.txt518 bytes

Hah, okay. I forgot that only modules in the Testing package can omit core and core_version_requirement.

  • japerry committed 665eb6c on 8.x-3.x authored by phenaproxima 
    Issue #3128339 by phenaproxima: Fix tests on Drupal 9 and drop support...
japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Needs review » Fixed

Looks good. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.