Once #3073604: Missing `config_export` in `search_api_page` entity definition. and #3123705: Deprecated code report are committed, it should be possible to declare this module compatible with Drupal 9.
I’m currently doing that for my own modules (Search API, Autocomplete and Saved Searches), and for testing purposes it would be handy if this module would follow soon.

CommentFileSizeAuthor
#9 3126605-9--declare_d9_compatibility--fix_tests.patch487 bytesdivyesh19
#6 3126605-5.patch352 bytesoknate
#5 3126605-4.patch350 bytesoknate
#2 3126605-2--declare_d9_compatibility.patch350 bytesdrunken monkey
#2 3126605-2--declare_d9_compatibility--with_deprecation_tests.patch1012 bytesdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Related issues: +#3073604: Missing `config_export` in `search_api_page` entity definition., +#3123705: Deprecated code report
FileSize
3126605-2--declare_d9_compatibility--with_deprecation_tests.patch1012 bytes
3126605-2--declare_d9_compatibility.patch350 bytes

Here are the relevant patches already – one for declaring compatibility, and one for checking whether this already works as it should.
As said, though, we’ll probably have to wait for the other two issues until this makes sense.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented

According to Berdir, it might also make sense to just make this part of #3123705: Deprecated code report. It’s up to you.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented

I'm getting an error with #2:

    https://www.drupal.org/files/issues/2020-04-10/3126605-2--declare_d9_compatibility.patch (3126605 Drupal 9 compatibility)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2020-04-10/3126605-2--declare_d9_compatibility.patch
oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
FileSize
3126605-4.patch350 bytes

Adding a different patch, to see if it applies.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
FileSize
3126605-5.patch352 bytes

still not applying, trying again.

s_leu’s picture

s_leu CreditAttribution: s_leu as a volunteer and commented

Just as a quick info here: I've added core_version_requirement in the latest patch posted in #3123705: Deprecated code report , so as already suggested in #3, probably would make most sense to move the work for this over there.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
Status: Postponed » Needs work

The other issues have been committed. I think it should all already be ok for drupal 9. I did not see this issue so I'm afraid I did not give credit to everyone.

This patch does not apply anymore, but it is no longer needed.

What we do need to do is to fix the tests. See also https://www.drupal.org/pift-ci-job/1808030 they fail on 9.1 with:

Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

This should hopefully be an easy fix.

divyesh19’s picture

divyesh19
his/him/he
Primary language English
CreditAttribution: divyesh19 at TATA Consultancy Services commented
Status: Needs work » Needs review
FileSize
3126605-9--declare_d9_compatibility--fix_tests.patch487 bytes

Added $defaultTheme.
Hoping tests would now pass for 9.1.

  • borisson_ committed 899a553 on 8.x-1.x authored by divyesh19 
    Issue #3126605 by drunken monkey, oknate, divyesh19: Declare...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
Status: Needs review » Fixed

Commited and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.