Add core_version_requirement: ^8 || ^9 to jw_player.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#4 jw_player-d8-3126556-4-interdiff.txt542 bytesBerdir
#4 jw_player-d8-3126556-4.patch25.47 KBBerdir
#3 jw_player-d8-3126556-3.patch25.46 KBBerdir
#2 3126556-2.patch366 bytesmo_farhaz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz CreditAttribution: mo_farhaz at Specbee commented
Assigned: mo_farhaz » Unassigned
Status: Active » Needs review
FileSize
3126556-2.patch366 bytes

core version requirement added.
please review it.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Priority: Minor » Normal
FileSize
jw_player-d8-3126556-3.patch25.46 KB

Lots of fixes, passing tests but tests only test a small part. Especially the libraries.module integration and trying to make that optional is challenging.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
FileSize
jw_player-d8-3126556-4.patch25.47 KB
jw_player-d8-3126556-4-interdiff.txt542 bytes

Fixing a missing /.

  • Berdir committed b82bdd8 on 8.x-1.x 
    Issue #3126556 by Berdir, mo_farhaz: Drupal 9 readiness
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Fixed

seems to work in manual testing, committing this.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.