Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The ./core/scripts/test-site.php
which is used by Nightwatch tests depend on localize.drupal.org. This has a potential of causing random failures in the case of localize.drupal.org not being reachable. We have reduced our dependency on external services in our PHP based tests in the past.
Proposed resolution
Mock localize.drupal.org when installing site with ./core/scripts/test-site.php
.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#5 | 3122002-5.patch | 580 bytes | clayfreeman |
#3 | 3122002-3.patch | 5.21 KB | clayfreeman |
Comments
Comment #2
dwwYes, please. ;) Given the impact this has on core development, seems this should be at least major...
Thanks,
-Derek
Comment #3
clayfreemanThe attached patch removes
\Drupal\TestSite\TestSiteMultilingualInstallTestScript
and consolidates its additional functionality into\Drupal\TestSite\TestSiteInstallTestScript
. This allows thelocale
module to skip retrieving the translation file for Drupal core on install.Comment #4
alexpott@clayfreeman how about changing the test to use core/tests/Drupal/TestSite/TestSiteMultilingualInstallTestScript.php
ie.
Change
setupFile: 'core/tests/Drupal/TestSite/TestSiteInstallTestScript.php'
tosetupFile: 'core/tests/Drupal/TestSite/TestSiteMultilingualInstallTestScript.php',
in core/tests/Drupal/TestSite/TestSiteMultilingualInstallTestScript.phpRemoving core/tests/Drupal/TestSite/TestSiteMultilingualInstallTestScript.php means any custom or contrib tests that use it will break.
Comment #5
clayfreemanComment #6
dww#5 looks great. Queued for a run on 9.1.x, too (although I believe the upstream problem is fixed where there was no 9.1.x po files for the installer on l.d.o, so it probably won't tell us much).
Tentatively +1 for an RTBC...
Comment #7
anu.a_95 CreditAttribution: anu.a_95 at Zyxware Technologies commentedApplied patch #5 successfully
The patch in #5 as per the suggestion in #4 looks great and is applied cleanly. The Drupal (9.1.x-dev) instance worked as normal after the patch.
-Thanks
Comment #8
anu.a_95 CreditAttribution: anu.a_95 at Zyxware Technologies commentedComment #9
alexpottCommitted and pushed bf2b32abc7 to 9.1.x and 0d9ca03d03 to 9.0.x and 6dca0459c6 to 8.9.x. Thanks!
Backported to 8.9.x as this is a test only change.
Coding standards fail due to: