Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
As title, https://www.drupal.org/project/coder/releases/8.x-3.8 released on 24 Mar 2020
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#11 | interdiff-7-11.txt | 1.2 KB | jungle |
#11 | 3121885-8.9.x-11.patch | 4.96 KB | jungle |
#5 | 3121885-5-8.8.x.patch | 11 KB | jungle |
#2 | 3121885-2-9.0.x.patch | 6.22 KB | jungle |
#2 | 3121885-2-8.9.x.patch | 11.26 KB | jungle |
Comments
Comment #2
jungleUpdated by reinstalling, correct me if this is a wrong way, thanks!
Comment #3
cilefen CreditAttribution: cilefen as a volunteer commentedActually the way it should be done is:
composer require --dev drupal/coder:^8.3.8 --update-with-dependencies
Comment #4
jungleThank you @cilefen for reviewing and correction!
Comment #5
jungleTrigger the tests against 8.8.x and 9.0.x later if 8.9.x patch passes
Comment #6
longwaveThis doesn't look right, this shouldn't be changing.
Upgrading this here is out of scope I think
Same with this
This doesn't look right either.
Comment #7
jungleThank you @longwave for reviewing and sharing to me the command below on slack
Comment #8
jungleComment #9
jungleComment #10
alexpottI've run phpcs with this patch on 9.0.x and 8.9.x. 9.0.x is fine but we need to fix 2 new coding standards issues on D8.9...
Comment #11
jungleThanks, @alexpott!
Comment #12
longwave#10 was addressed so this looks ready to go.
Comment #13
jungle@longwave, Thank you!
And one more question for @alexpott, how did you found that? Frankly, I did not reproduce that on my local and DrupalCI did not detect out them too, https://www.drupal.org/pift-ci-job/1626085 (from #7)
So could you share to me the steps or commands you run if it's not time-consuming? Your time is precious, do not want to take much your time. I could still try to figure it out myself. Thanks!
Comment #14
alexpott@jungle on 8.9.x after applying #7 and running composer install, I ran the following command:
composer run phpcs -- -ps
. Core's root composer.json has a command that sets up phpcs properly and uses the correct phpcs.xml etc.Comment #15
jungle@alexpott many thanks!
Reproduced #10 with your command
composer run phpcs -- -ps
But one thing makes me confusing, and can't find an explanation from the documentation of phpcs
From the console, the actual command was
> phpcs --standard=core/phpcs.xml.dist --runtime-set installed_paths $($COMPOSER_BINARY config vendor-dir)/drupal/coder/coder_sniffer -- '-ps'
In composer.json
From my understanding,
composer run phpcs -- -ps
should be expended to> phpcs --standard=core/phpcs.xml.dist --runtime-set installed_paths $($COMPOSER_BINARY config vendor-dir)/drupal/coder/coder_sniffer -- -- '-ps'
Remove the tail
--
from the command in composer.json, it seems working too.Comment #16
alexpottCommitted and pushed f7e6636652 to 9.1.x and 2e30f2c179 to 9.0.x. Thanks!
Committed 6a83036 and pushed to 8.9.x. Thanks!
As a dev only dependency this is fine to update.