When adding @throws tags to SearchApiCommands in #2933811: Clean up new Drush code, we added those at the bottom of the doc blocks – after the Drush annotations. They would make more sense above the Drush annotations, with the rest of the normal docblock tags (@param, @return, etc.) and should just be moved.

CommentFileSizeAuthor
#3 Captura de tela de 2020-04-07 09-55-51.png214.73 KBilgnerfagundes
#2 3120909-2--clean_up_drush_docblock_tags_order.patch12.98 KBdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Active » Needs review
FileSize
3120909-2--clean_up_drush_docblock_tags_order.patch12.98 KB
ilgnerfagundes’s picture

ilgnerfagundes CreditAttribution: ilgnerfagundes at CI&T commented
Status: Needs review » Reviewed & tested by the community
FileSize
Captura de tela de 2020-04-07 09-55-51.png214.73 KB

It looks correct now

  • drunken monkey committed 49fe36d on 8.x-1.x 
    Issue #3120909 by drunken monkey: Cleaned up @throws tags in Drush code.
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Good to hear, thanks for reviewing!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.