When you try to select the creation state in workflow notifications you can not select the creation state. That´s a weird way to start as you may need a creation trigger. I have changed workflow call to be possible to see creation state. I have also corrected some mistypo in different files from source code.

I attach the patch file with all the changes in the module.

I will appreciate your feedback
Regards, Ricardo

CommentFileSizeAuthor
#5 workflow_3119998_5_creation_state.patch795 bytesjohnv
workflow.txt1.54 KBrhsantos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rhsantos created an issue. See original summary.

  • johnv committed e526e9a on 8.x-1.x 
    Issue #3119998 by rhsantos: Correction of spelling error
johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented

I have corrected the typo's. Thanks.

Pleaser see my comments in #3120004: Create Notification with create state

johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Version: 8.x-1.0-beta6 » 8.x-1.1
Status: Active » Postponed (maintainer needs more info)

Please check if your problem still applies. I cannot find back your change in the current code. Please provide a new patch.

johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Version: 8.x-1.1 » 8.x-1.x-dev
Status: Postponed (maintainer needs more info) » Needs review
FileSize
workflow_3119998_5_creation_state.patch795 bytes

I guess attached patch is the residue of your original one. I need to test it.

Status: Needs review » Needs work

The last submitted patch, 5: workflow_3119998_5_creation_state.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Title: Workflow Creation Selected and mystyped text » Select Creation state in Workflow notifications module

  • johnv committed cf8626f on 8.x-1.x authored by rhsantos 
    Issue #3119998 by rhsantos: Select Creation state in Workflow...
johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Version: 8.x-1.x-dev » 8.x-1.4
Status: Needs work » Fixed

I could not test this in the exact use case. but committed anyway.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.