We likely missed this because it's a lazy builder callback that, when big pipe is enabled, is too late to be reported as a deprecation.

This will also require to update the .info.yml to require ^8.8 because it was introduced in https://www.drupal.org/node/2966725

CommentFileSizeAuthor
#4 3119772-3-fixed.patch4.58 KBandypost
#3 3119772-3.patch8.69 KBandypost
#3 interdiff.txt3 KBandypost
#2 masquerade-callback-3119772-2.patch4.61 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new masquerade-callback-3119772-2.patch4.61 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt3 KB
new 3119772-3.patch8.69 KB

It needs to put masquerade_target_user_access() into service as well to properly implement DI

Also we can get rid of renderer dependency here

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 3119772-3-fixed.patch4.58 KB

valid patch

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes

added link to CR to summary

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Reviewed & tested by the community

Seems valid to me.

  • andypost committed aa621dd on 8.x-2.x 
    Issue #3119772 by andypost, Berdir: masquerade_render_cache_link needs...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed
andypost’s picture

andypost
he/him
Primary language Russian
commented

New release is out https://www.drupal.org/project/masquerade/releases/8.x-2.0-beta4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.