Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
We can remove the lowercase table naming in NodeMigrateTypeTestTrait::getTableName() for PostgreSQL, because #2986452: Database reserved keywords need to be quoted as per the ANSI standard has landed for Drupal 9.0.
Comment | File | Size | Author |
---|---|---|---|
#2 | 3119710-2.patch | 1.11 KB | daffie |
Comments
Comment #2
daffie CreditAttribution: daffie commentedComment #3
Kristen PolComment #4
Kristen PolThanks for the patch.
1) Patch looks good.
2) Patch applies cleanly.
3) Checked that
getTableName
is only used in:core/modules/migrate_drupal/tests/src/Traits/NodeMigrateTypeTestTrait.php
4) Tests pass so marking RTBC.
Comment #7
catchCommitted 8c8056e and pushed to 9.1.x, cherry-picked to 9.0.x. Thanks!
Comment #8
daffie CreditAttribution: daffie commented@Kirsten Pol: Thank you for all your reviewing efforts!
Comment #9
Kristen Pol@daffie Thanks for the patch!