We can remove the lowercase table naming in NodeMigrateTypeTestTrait::getTableName() for PostgreSQL, because #2986452: Database reserved keywords need to be quoted as per the ANSI standard has landed for Drupal 9.0.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie created an issue. See original summary.

daffie’s picture

Status: Active » Needs review
FileSize
1.11 KB
Kristen Pol’s picture

Assigned: Unassigned » Kristen Pol
Kristen Pol’s picture

Assigned: Kristen Pol » Unassigned
Status: Needs review » Reviewed & tested by the community

Thanks for the patch.

1) Patch looks good.

2) Patch applies cleanly.

[mac:kristen:drupal-9.0.x-dev]$ patch -p1 < 3119710-2.patch 
patching file core/modules/migrate_drupal/tests/src/Traits/NodeMigrateTypeTestTrait.php

3) Checked that getTableName is only used in:

core/modules/migrate_drupal/tests/src/Traits/NodeMigrateTypeTestTrait.php

4) Tests pass so marking RTBC.

  • catch committed 8c8056e on 9.1.x
    Issue #3119710 by daffie, Kristen Pol: Remove lowercase table naming in...

  • catch committed ec1f4b7 on 9.0.x
    Issue #3119710 by daffie, Kristen Pol: Remove lowercase table naming in...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed 8c8056e and pushed to 9.1.x, cherry-picked to 9.0.x. Thanks!

daffie’s picture

@Kirsten Pol: Thank you for all your reviewing efforts!

Kristen Pol’s picture

@daffie Thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.