See the following Search API issue/comment: #3056940-4: The "media_type" entity type does not exist..

There, we see an uncaught exception propagated from this module – specifically, the FilesExtractor processor. This is apparently caused by updating Search API Solr to 3.x while still staying on the contrib Media module instead of switching to the Core alternative.
However, in the code, it’s apparent that there could potentially be uncaught exceptions in other cases, too. I think we should just wrap that code in try/catch.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
2.91 KB

Please see the attached patch draft and tell me what you think!
(I’m not sure what kind of logging or code style you would prefer, that’s why it’s only a draft.)

izus’s picture

hi,

i'm ok with that. thanks :)
we can just $this->logger->log() the plugin id concerned by InvalidPluginDefinitionException or PluginNotFoundException exceptions

Thanks a lot

izus’s picture

Status: Needs review » Needs work
drunken monkey’s picture

Status: Needs work » Needs review
FileSize
2.27 KB
2.92 KB

Alright. Something like this?

  • drunken monkey authored 0a18e3f on 8.x-1.x
    Issue #3117949 by drunken monkey, izus: Improve exception handling in...
izus’s picture

Status: Needs review » Fixed

This is now merged

thanks a lot

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.