CommentFileSizeAuthor
#6 3117060-6.patch1 KBmrinalini9
#4 interdiff-3117060-2-4.txt427 bytesmrinalini9
#4 3117060-4.patch1.06 KBmrinalini9
#2 3117060-2.patch1.07 KBswatichouhan012
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swatichouhan012 created an issue. See original summary.

swatichouhan012’s picture

swatichouhan012 CreditAttribution: swatichouhan012 at Valuebound for Valuebound commented
Assigned: swatichouhan012 » Unassigned
Status: Active » Needs review
FileSize
3117060-2.patch1.07 KB

kindly review patch.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Needs work 
+++ b/testing_example/tests/modules/testing_example_test/testing_example_test.info.yml
@@ -5,4 +5,4 @@ description: "Mock module for the Testing Example module."
-  - testing_example
+  - testing_example:testing_example

Should be examples:testing_example

mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3117060-4.patch1.06 KB
interdiff-3117060-2-4.txt427 bytes

Updated patch as per the changes suggested in #3, please review.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Version: 8.x-1.x-dev » 3.x-dev
mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3117060-6.patch1 KB

Rerolled patch for 3.x, please review.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community

Nice, thank you

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented 

FILE: ...les/examples_description_test/examples_description_test.info.yml
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | WARNING | All dependencies must be prefixed with the project
   |         | name, for example "drupal:"
   |         | (DrupalPractice.InfoFiles.NamespacedDependency.NonNamespaced)
----------------------------------------------------------------------


FILE: ...tests/modules/testing_example_test/testing_example_test.info.yml
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 9 | WARNING | All dependencies must be prefixed with the project
   |         | name, for example "drupal:"
   |         | (DrupalPractice.InfoFiles.NamespacedDependency.NonNamespaced)
----------------------------------------------------------------------

Double checked. Thanks! Committing next.

  • jungle committed c86fd17 on 3.x authored by mrinalini9 
    Issue #3117060 by mrinalini9, swatichouhan012, jungle, andypost:  All...
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Version: 3.x-dev » 8.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Not sure whether this should be ported to 8.x-1.x. No CR-relevant found

  • jungle committed 6abf6f2 on 8.x-1.x authored by mrinalini9 
    Issue #3117060 by mrinalini9, swatichouhan012, jungle, andypost:  All...
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Patch (to be ported) » Reviewed & tested by the community

++ to 8.x

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Reviewed & tested by the community » Fixed

@valthebald also agreed on slack. Thanks, @andypost!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.