One of the ways the bug in #2979882: "The machine-readable name is already in use" error when adding multiple source keys can be reproduced, is in the following way:
- Add a target
- From the sources select list, select "New custom source.." and type in a source value.
- Configure target configuration.
So to write a test for the bug, it would be good to involve setting target configuration for it. There's however no test coverage for this action yet and it is stated as @todo
in FeedsJavascriptTestBase::addMappings()
.
So let's add that. And while we are at it, break down FeedsJavascriptTestBase::addMappings()
into multiple methods so the other issue could more easily do steps on the mapping form in a different order. Because the bug from the other issue is not exposed when setting target configuration first and set custom sources after.
Patch will follow.
Comment | File | Size | Author |
---|---|---|---|
#2 | feeds-js-test-coverage-set-target-configuration-3116977-2.patch | 10.03 KB | MegaChriz |
|
Comments
Comment #2
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedComment #4
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedCommitted #2.