Correct latest revision for node 1 in drupal6 test fixture

Correct comment config entities.

Yeah, the comment count seems wrong, I noticed that one of the comments comes over as the 'comment' bundle, instead of the story specific comment bundle, This definitly needs more work, I'll try to investigate further.

rtbc

1 new CS violoation:

/var/lib/drupalci/workspace/jenkins-drupal_patches-55597/source/core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeTest.php ✗ 1 more
line 63	Empty PHP statement detected: superfluous semi-colon.

+++ b/core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeTest.php
@@ -52,24 +52,24 @@ public function testNode() {
+    $this->assertIdentical('1420861423', $node->getRevisionCreationTime());;

Extra semicolon here.

Otherwise, seems RTBC to me. I'm only recently in touch with this test, so I'm no expert...

Bot's happy.
Tests pass.
No more CS violations.
Changes in the patch look consistent with the issue summary.

I could complain that if we're already changing assertions like this:

+++ b/core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeTest.php
@@ -52,24 +52,24 @@ public function testNode() {
+    $this->assertIdentical('Test title rev 3', $node->getTitle(), 'Node has the correct title.');
...
+    $this->assertIdentical('2', $node_revision->getRevisionUser()->id(), 'Node revision has the correct user');

...that we should strip the pointless 3rd message argument. But that's arguably out of scope. We'll clean all that up in other issues.

Therefore, RTBC.

Thanks,
-Derek

I took a look at this but have no idea what I'm looking at 😵

I'll ping @quietone to walk me through this tomorrow.

For the record, this patch is also making it consistent so that vid 5 always belongs to nid 1. E.g. currently (in Git, prior to the patch) we have:

~line 45316

->values(array(
  'nid' => '1',
  'vid' => '5',
  'uid' => '1',
  'title' => 'Test title rev 2',
  'body' => 'body test rev 2',
  'teaser' => 'teaser test rev 2',
  'log' => 'modified rev 2',
  'timestamp' => '1390095703',
  'format' => '1',
))

vs. a few spots where it's nid '2' (touched by the patch). E.g.:

~line 2404

->values(array(
  'vid' => '5',
  'nid' => '2',
  'field_test_value' => NULL,
  'field_test_format' => NULL,
))

...

+++ b/core/modules/migrate_drupal/tests/fixtures/drupal6.php
@@ -2274,6 +2274,20 @@
+->values(array(
...
+))
+->values(array(
...
+))

@@ -2413,6 +2421,12 @@
+->values(array(
...
+))

@@ -48083,6 +48114,16 @@
+->values(array(
...
+))
...
+))

@@ -48291,6 +48340,14 @@
+->values(array(
...
+))

Should we replace array() with []?

Committed ba77d3f and pushed to 9.1.x. Thanks!

c/p to 9.0.x

Queuing an 8.9.x test

Re-roll looks good. Back to RTBC.

Thanks!
-Derek

Committed 67b02fd and pushed to 8.9.x. Thanks!