I find myself reviewing / fixing a bunch of update.module issues these days. I'm basically maintaining it once more. I'm willing to make it official again, so we can remove another ? from MAINTAINERS.txt

Wonder if @tedbow wants to join me. They're definitely the other logical choice.

CommentFileSizeAuthor
#17 3116804-17.do-not-test.patch498 bytesdww
#2 3116804-2.do-not-test.patch377 bytesdww
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww created an issue. See original summary.

dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented
Title: Make dww a maintainer for update module (again) » Make dww a maintainer for Update module (again)
Status: Active » Needs review
FileSize
3116804-2.do-not-test.patch377 bytes
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

+1 from me. Derek is the ideal choice.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented

+1 from me. I have worked with @dww on series of critical issues recently on the update module and they just got committed 🎉. Thanks for volunteering!

Wonder if @tedbow wants to join me. They're definitely the other logical choice.

Thanks for saying so! I have thought about this and still thinking on this. Will let you know

+++ b/core/MAINTAINERS.txt
@@ -435,7 +435,7 @@ Umami demo
 Update UI

Out of scope but we should create an issue to change this to the same name as in update.info.yml 😜

dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented

Thanks, @heddn and @tedbow, for the kind words and votes of confidence.

Re: #4: Sounds good. ;) #3116909: [PP-1] Change "Update UI" to "Update Manager" in MAINTAINERS.txt

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
CreditAttribution: benjifisher commented

+1 from me.

I have worked on some of the recent issues mentioned in#4. Derek has valuable long-term knowledge of the system, attention to detail, and works to get feedback and buy-in as needed. As #4 shows, Derek is always ready to file the needed follow-up issue, not just do the fun part of writing the patches.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
CreditAttribution: benjifisher as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Three votes in favor, none opposed. For good measure, I actually looked at the patch. Let's update the status of this issue.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented

+∞ from me to @dww, my mentor :)

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
Issue tags: +Project governance

RTBC++

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer and commented

I wonder, what's holding this one back from being committed?

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Hi @Spokje, we were doing some work with @dww to improve communication, patch review, and issue management, and wanted to make sure we had a good team for the Update module. And it has gone well!

@dww has done great work this past year, so if he is still interested I think we can go ahead with this appointment. We also want to make sure to appoint @tedbow at the same time so that the component has a good maintainer balance.

Thanks @Spokje and of course @dww!

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented

Offering to help too #3218346: Add tedbow as a maintainer for Update module

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented
Related issues: +#3218346: Add tedbow as a maintainer for Update module
dww’s picture

dww
we/he/they
CreditAttribution: dww at TEN7 commented
Title: Make dww a maintainer for Update module (again) » Add tedbow and dww as maintainers for Update Manager
FileSize
3116804-17.do-not-test.patch498 bytes

Great, thanks all around! Last I heard, @tedbow declined the invite. Happy to see that changed! Since #3218346: Add tedbow as a maintainer for Update module is RTBC without a patch, and since #3116909: [PP-1] Change "Update UI" to "Update Manager" in MAINTAINERS.txt seems best, let's just take care of it all with the least committer effort and fix it all here.

Yay,
-Derek

  • xjm committed a9af2c6 on 9.3.x 
    Issue #3116804 by dww, tedbow, benjifisher, heddn, xjm, jungle: Add...

  • xjm committed 798ec58 on 9.2.x 
    Issue #3116804 by dww, tedbow, benjifisher, heddn, xjm, jungle: Add...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Alright, I'm OK with the updated scope here. Normally these should all be three separate issues despite the merge-conflict-y-ness, but since all three are committable as far as I'm concerned, we don't need to do the busywork of a series of three commits with three tedious patches. :)

Committed to 9.3.x and 9.2.x. I didn't backport it to 8.9.x because we're putting that branch in security-only mode now.

Thanks @dww and @tedbow for volunteering for this!

dww’s picture

dww
we/he/they
CreditAttribution: dww at TEN7 commented

Thanks, @xjm! You had also said: "We also want to make sure to appoint @tedbow at the same time..." so 1 patch seemed the easiest way to do that.

Anyway, huzzah! 1 more ? gone from MAINTAINERS.txt! :)

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented

thanks @xjm!

Whoops, about not providing the patch on the other issue 🙃

Yay, on removing the "?" from maintainers.txt.

Congrats @dww, looking forward to working with you

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented

Thanks so much, both! This is a particularly important '?' to eliminate. :D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.