Shipping method formatter does not respect the given langcode parameter

Thanks, mbovan!

Shouldn't we use the same code as in ShipmentManager:

$shipping_method = $this->entityRepository->getTranslationFromContext($shipping_method);

The getTranslationFromContext() method accepts a $langcode as a second parameter.

Of course, needs $this->entityRepository to be injected, and some manual testing at least.

What @bojanz said, was going to comment the same.

1. +++ b/src/Plugin/Field/FieldFormatter/ShippingMethodFormatter.php
   @@ -19,7 +22,55 @@ use Drupal\Core\Field\FormatterBase;
     * )
     */
   -class ShippingMethodFormatter extends FormatterBase {
   +class ShippingMethodFormatter extends FormatterBase implements ContainerFactoryPluginInterface {
   +
   +  /**
   +   * The entity repository.
   +   *
   +   * @var \Drupal\Core\Entity\EntityRepositoryInterface
   +   */
   +  protected $entityRepository;
   +
   

   This _might_ break subclasses if they have their own constructor, but commerce_shipping is still in beta and there have been tons of changes recently, so I assume @bojanz is fine with that.

   And FormatterBase only implements ContainerFactoryPluginInterface in 8.8, so we'd need to require that to do the trick with assigning stuff in create() + parent call.

2. +++ b/tests/src/Kernel/Formatter/ShippingMethodFormatterTest.php
   @@ -16,6 +17,32 @@ use Drupal\Tests\commerce_shipping\Kernel\ShippingKernelTestBase;
   +    $this->container->get('content_translation.manager')->setEnabled('commerce_shipping_method', 'commerce_shipping_method', TRUE);
   
   @@ -53,6 +93,20 @@ class ShippingMethodFormatterTest extends ShippingKernelTestBase {
    
   +    $default_language = $this->container->get('language_manager')->getDefaultLanguage();
   +    $this->container->get('language.default')->set($this->translationLanguage);
   

   I prefer using \Drupal::languageManager()/service() in tests, but not enough context in the diff to see how the tests is doing these calls currently, if there are any. Not a big deal and could be changed on commit.

Thank you both!

I prefer $this->container in tests so I've kept the code as-is.