Adding a taxonomy term should trigger a drupal_set_message() so people know somehting happened.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Souvent22’s picture

Drumm,

I have it fixed/patched, but before I post, we got some options:

Current way is that after adding a term, it stays on the "add terms" page....
So...
A) After adding, take me back to add terms for another one.
B) After adding, take me back to my list of terms for that vocab.
C) Give me a check box that says "Add another after sumbission"

During SAT's, they always said B was the right answer...or was it C..hmm....ideas suggestions?

m3avrck’s picture

I would say go with B. That is the general behavior in the rest of Drupal, might as well be consistent. And the checkbox doesn't help that much... extra click (I'm assumed off by default) and the user can just click 'add' again anywho.

Souvent22’s picture

Status: Active » Needs review
FileSize
943 bytes

B it is.

m3avrck’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
943 bytes

Tested patch, definetly improves usability of taxonomy module and adding terms. Before, it wasn't clear if a term was added or not. This also makes adding a term more consistent with how the rest of Drupal works (e.g., taking you back to the main add term page instead of a blank form wondering what just happened).

Fixed coding style of patch. Ready to go.

Morbus Iff’s picture

Status: Reviewed & tested by the community » Needs work

Somewhere along the line, I think "visual feedback when terms were added" was actually REMOVED when the free tagging patch hit core. Consider: you write a node, with free tagging enabled, and you create 10 new terms. Upon successful submission of a node, you get ten messages saying new terms were added. That may be find for an administrator, but I certainly wouldn't want a regular non-admin or non-taxonomy-admin user seeing a message that they've added a new term.

robertDouglass’s picture

Status: Needs work » Reviewed & tested by the community

+1 for the message. I thought that going back to the add-term form was by design, and personally, I like it. I often have to add lots of terms in a row, to the same vocab, and this saves me a page load each time. So -1 for drupal_goto('admin/taxonomy/' . arg(2));.

robertDouglass’s picture

RE Morbus's comment - we could check to see if the user is looking at the admin/taxonomy/vid/add/term path and only show the message then.

Morbus Iff’s picture

(Toggling back to "needs work" per my comment in #5 - Rob's comment and my own crossed in the stream).

Morbus Iff’s picture

Status: Reviewed & tested by the community » Needs work
Kobus’s picture

I am with Robert here (#6) +1 for the message, -1 for the drupal_goto. The feature of adding several terms after each other is very handy.

Kobus

m3avrck’s picture

Status: Needs work » Needs review
FileSize
957 bytes

New patch that fixes the goto() and sends you back to add another term, displaying a message that a term has been added.

Tested with free tagging, this patch does not output any messages saying "term 1 created", "term 2 created" , etc. All that is output is "Page was created" so Morbus your issued is already addressed elsewhere.

drumm’s picture

Assigned: drumm » Unassigned
Dries’s picture

Status: Needs review » Needs work

Patch no longer applies, but needed.

Jaza’s picture

Status: Needs work » Needs review
FileSize
884 bytes

New patch that restores the feedback message when a new term is added. Feedback message is not displayed when adding free-tagging terms through the node add/edit screen.

Jaza’s picture

Assigned: Unassigned » Jaza
m3avrck’s picture

Patch works, however the code can be cleaned up a bit, the test $op != t('Submit') is duplicated in this patch.

Jaza’s picture

Category: task » bug
Status: Needs review » Reviewed & tested by the community
FileSize
997 bytes

Oops.. thought I removed that duplicate line! New patch has this cleaned up.

Richard Archer’s picture

+1 This patch works for me.

Dries’s picture

Status: Reviewed & tested by the community » Needs work

When you submit a new term, you should end up on the term overview page.

m3avrck’s picture

Dries, there was a lot of talk about this. That was my original thought too, but too many people said they liked the fact that there on the 'add term' page again so they could input a lot of terms really fast without clicking everywhere. That is how it currently works, this patch above changed it to what you said, got a lot of flak, and it was reverted once again. I'm mixed as to what the best approach is.

webchick’s picture

Yes, please *don't* send me back to the overview page after adding a term. A lot of my vocabs have upwards of 20+ terms and if I had to click "Add term" each time that would drive be more bonkers than I already am. :P

m3avrck’s picture

Status: Needs work » Reviewed & tested by the community

Right, that seems to be the general opinion, in which case this patch still applies :-)

Jaza’s picture

Agreed: sending the user back to the overview page is a PITA. (Which is why my patch doesn't do it ;)).

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)