Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
This @todo regarding fieldset CSS pops up in a few places.
* @todo remove once this Mozilla bug is fixed.
* See https://bugzilla.mozilla.org/show_bug.cgi?id=504622
The Mozilla bug is fixed
Proposed resolution
Remove the CSS. Provide screenshots to prove the removal is not unpleasant.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#2 | FF-without-workaround.png | 90.46 KB | bnjmnm |
#2 | FF-with-workaround.png | 70.53 KB | bnjmnm |
#2 | chrome-as-reference.png | 94.8 KB | bnjmnm |
#2 | 3115005-2.patch | 1.75 KB | bnjmnm |
Comments
Comment #2
bnjmnmThe rule is removed. Here are some reference screenshots.
Here are fieldsets in Chrome, a browser that was not impacted by the workaround:
These are fieldsets in Firefox with the
display: table-cell
workaround that is no longer necessary. Notice that there's more top/bottom space separating the fieldsetsThese are fieldsets in Firefox with this patch applied, removing the no-longer-necessary workaround. There's no longer a bug, and it now better matches other browsers.
Comment #3
joachim CreditAttribution: joachim commentedLGTM.
Comment #4
alexpottYep this is inline with our browser policy - https://www.drupal.org/node/3079238 this was fix ed in Firefox 53 - they're on 74 now.
Committed 00ebcd9b83 and pushed to 9.0.x.
Committed c81afb8 and pushed to 8.9.x. Thanks!